Skip to content

Conversation

@ganeshvanahalli
Copy link
Contributor

@ganeshvanahalli ganeshvanahalli commented Nov 10, 2025

Pulls in testnode PR- OffchainLabs/nitro-testnode#165
Resolves NIT-3859

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
2174 3 2171 0
View the top 3 failed tests by shortest run time
TestRedisProduceComplex/one_producer,_all_consumers_are_active
Stack Traces | 2.020s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[36mDEBUG�[0m[11-28|19:05:43.655] redis producer: check responses starting
�[36mDEBUG�[0m[11-28|19:05:43.655] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=1
�[36mDEBUG�[0m[11-28|19:05:43.660] redis producer: check responses starting
�[36mDEBUG�[0m[11-28|19:05:43.661] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=1
�[36mDEBUG�[0m[11-28|19:05:43.667] redis producer: check responses starting
�[36mDEBUG�[0m[11-28|19:05:43.670] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=1
�[36mDEBUG�[0m[11-28|19:05:43.676] redis producer: check responses starting
�[36mDEBUG�[0m[11-28|19:05:43.677] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=1
�[36mDEBUG�[0m[11-28|19:05:43.682] redis producer: check responses starting
�[36mDEBUG�[0m[11-28|19:05:43.682] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=1
�[36mDEBUG�[0m[11-28|19:05:43.687] redis producer: check responses starting
�[36mDEBUG�[0m[11-28|19:05:43.689] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=1
�[36mDEBUG�[0m[11-28|19:05:43.696] redis producer: check responses starting
�[36mDEBUG�[0m[11-28|19:05:43.698] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=0 �[36mchecked�[0m=1
�[36mDEBUG�[0m[11-28|19:05:43.703] redis producer: check responses starting
�[36mDEBUG�[0m[11-28|19:05:43.704] request timed out waiting for response   �[36mmsgId�[0m=1764356741700-20 �[36mallowedOldestId�[0m=1764356741703-0
�[36mDEBUG�[0m[11-28|19:05:43.704] checkResponses                           �[36mresponded�[0m=0  �[36merrored�[0m=1 �[36mchecked�[0m=1
    pubsub_test.go:320: Error awaiting responses from promises 0: [82]
�[31mERROR�[0m[11-28|19:05:43.706] Error from XpendingExt in getting PEL for auto claim �[31merr�[0m="context canceled" �[31mpenindlen�[0m=0
--- FAIL: TestRedisProduceComplex/one_producer,_all_consumers_are_active (2.02s)
TestRedisProduceComplex
Stack Traces | 10.720s run time
=== RUN   TestRedisProduceComplex
=== PAUSE TestRedisProduceComplex
=== CONT  TestRedisProduceComplex
--- FAIL: TestRedisProduceComplex (10.72s)
TestVersion30
Stack Traces | 12.640s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestVersion30
=== CONT  TestVersion30
    precompile_inclusion_test.go:94: goroutine 456115 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40e4bb0, 0xc018605a40}, {0x40a2440, 0xc0f179fef0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc018605a40, {0x40a2440, 0xc0f179fef0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc018605a40, 0x1e, {0xc08eb79db0, 0x6, 0x0?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:94 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc018605a40?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc018605a40, 0x3d27bb0)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (12.64s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

KolbyML
KolbyML previously approved these changes Nov 10, 2025
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

amsanghi
amsanghi previously approved these changes Nov 11, 2025
@amsanghi amsanghi assigned eljobe and unassigned amsanghi Nov 11, 2025
@ganeshvanahalli ganeshvanahalli dismissed stale reviews from KolbyML and amsanghi via 7d2c325 November 17, 2025 19:34
@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review November 17, 2025 19:34
@rauljordan
Copy link
Contributor

conflicts @ganeshvanahalli

Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 added this pull request to the merge queue Dec 2, 2025
Merged via the queue into master with commit 6723698 Dec 2, 2025
36 of 37 checks passed
@joshuacolvin0 joshuacolvin0 deleted the update-testnode-pin-PR149 branch December 2, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants