Introduce continuous mode to JIT Validator #4269
Open
+1,776
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bragaigor
commented
Jan 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4269 +/- ##
==========================================
- Coverage 33.04% 32.49% -0.55%
==========================================
Files 482 482
Lines 57028 57028
==========================================
- Hits 18843 18533 -310
- Misses 34778 35252 +474
+ Partials 3407 3243 -164 |
Contributor
❌ 7 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Signed-off-by: Igor Braga <[email protected]>
bragaigor
force-pushed
the
braga/only-validation-cont-mode
branch
from
85a7be7 to
0f651ac
Compare
pmikolajczyk41
requested changes
Jan 23, 2026
Merged
Add test related to server lifecycle and update complete_machine to kill parent process instead of waiting for it Signed-off-by: Igor Braga <[email protected]>
bragaigor
commented
Jan 26, 2026
Signed-off-by: Igor Braga <[email protected]>
Signed-off-by: Igor Braga <[email protected]>
Signed-off-by: Igor Braga <[email protected]>
Signed-off-by: Igor Braga <[email protected]>
Signed-off-by: Igor Braga <[email protected]>
bragaigor
commented
Jan 27, 2026
Ignoring the test since the workflow this is run does not have a jit binary available so it's failing with `No such file or directory`. Support for it will come in a separate PR Signed-off-by: Igor Braga <[email protected]>
Signed-off-by: Igor Braga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce continuous mode for JIT Validator. Unlike "Native" mode (which runs logic in-process), this module manages a persistent subprocess (
jit) to perform validation. The communication protocol handles the exchange of validation inputs (batches, preimages, WASM binaries) and outputs (new state). This mode is the equivalent of current JIT Validator functionality in Go, where main logic can be found here:nitro/validator/server_jit/jit_machine.go
Line 73 in 3e85df6
Default mode is set to "Native".
Some functionality like
JitLocatoris left out on purpose as those will be introduced in a separate PR. This other PR shows a more holistic view of how everything will eventually fit together.This PR also introduces Validator graceful shutdown mechanism in case it receives certain signals.
Closes NIT-4305