Hooking before the first IO instruction in replay.wasm
#4283
+25
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmikolajczyk41
requested review from
bragaigor,
diegoximenes,
joshuacolvin0 and
tsahee
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4283 +/- ##
==========================================
+ Coverage 34.58% 34.65% +0.06%
==========================================
Files 475 475
Lines 56720 56722 +2
==========================================
+ Hits 19619 19655 +36
+ Misses 33633 33603 -30
+ Partials 3468 3464 -4 |
Contributor
❌ 4 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
bragaigor
approved these changes
Jan 28, 2026
| "keccak256" => func!(arbkeccak::keccak256), | ||
| }, | ||
| "hooks" => { | ||
| "beforeFirstIO" => func!(|_: WasmEnvMut|{}), |
Contributor
There was a problem hiding this comment.
implementation will be done in another PR?
Contributor
There was a problem hiding this comment.
JIT and Arbitrator provers have noop implementations.
that's why
| func validateCertificate(ty uint32, hash unsafe.Pointer) uint32 | ||
|
|
||
| //go:wasmimport hooks beforeFirstIO | ||
| func beforeFirstIO() |
Contributor
There was a problem hiding this comment.
nitpick: maybe actionBeforeFirstIO but that doesn't make that much difference. beforeFirstIO already implies action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replay.wasmwe call a hook. For native compilation, it's a noop. For wasm, we expect that the execution environment will provide a module calledhookswith a methodbeforeFirstIO.sp1__dumpElf(as in Add a new Succinct SP1 based arbitrator-like runner #4170)wavmio/stub.gotowavmio/native.go(it's not about stubbing, but runningreplay.wasmas a native binary instead).StubInitandStubFinaltoOnInitandOnFinal, so that together with the newOnReady, they compose a triple ofwavmiolifecycle hooks called directly fromreplay.wasm.closes NIT-4401