Improve inline comments in retryable precompile

[gligneul]

Close NIT-4120

[codecov]

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.53%. Comparing base (db29e55) to head (11ccf3c).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4286       +/-   ##
===========================================
- Coverage   57.12%   34.53%   -22.60%     
===========================================
  Files         476      476               
  Lines       56785    56786        +1     
===========================================
- Hits        32441    19612    -12829     
- Misses      19506    33690    +14184     
+ Partials     4838     3484     -1354     

[github-actions]

❌ 5 Tests Failed:

Tests completed	Failed	Passed	Skipped
4024	5	4019	0

View the top 3 failed tests by shortest run time

TestVersion30

Stack Traces | 6.670s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
INFO [01-28|18:55:56.204] Stopping work on payload                 id=0x034da02a669cf305 reason=delivery
INFO [01-28|18:55:56.204] Writing cached state to disk             block=1   hash=aae6b9..550fa7 root=8448b4..050cee
INFO [01-28|18:55:56.204] Persisted trie from memory database      nodes=20   flushnodes=0 size=3.26KiB   flushsize=0.00B time="121.657µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime="1.571µs"  livenodes=0    livesize=0.00B
INFO [01-28|18:55:56.205] Writing cached state to disk             block=1   hash=aae6b9..550fa7 root=8448b4..050cee
INFO [01-28|18:55:56.205] Persisted trie from memory database      nodes=0    flushnodes=0 size=0.00B     flushsize=0.00B time=942ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=0    livesize=0.00B
INFO [01-28|18:55:56.205] Writing snapshot state to disk           root=6b754c..7398ca
INFO [01-28|18:55:56.205] Persisted trie from memory database      nodes=0    flushnodes=0 size=0.00B     flushsize=0.00B time=381ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=0    livesize=0.00B
INFO [01-28|18:55:56.205] Blockchain stopped
WARN [01-28|18:55:56.205] Served eth_call                          reqid=11    duration=5.23557929s   err="execution aborted (timeout = 5s)"
--- FAIL: TestVersion30 (6.67s)
INFO [01-28|18:55:56.206] Writing cached state to disk             block=1   hash=36d1d1..cfb1be root=d45d64..4e7811
INFO [01-28|18:55:56.206] Chain head was updated                   number=461 hash=803043..74f107 root=7c70e4..19789c elapsed="159.487µs"
INFO [01-28|18:55:56.206] Persisted trie from memory database      nodes=23   flushnodes=0 size=3.61KiB   flushsize=0.00B time="437.596µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime="1.644µs"  livenodes=0    livesize=0.00B
INFO [01-28|18:55:56.206] Writing cached state to disk             block=1   hash=36d1d1..cfb1be root=d45d64..4e7811
INFO [01-28|18:55:56.206] Persisted trie from memory database      nodes=0    flushnodes=0 size=0.00B     flushsize=0.00B time="1.192µs"   flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=0    livesize=0.00B
INFO [01-28|18:55:56.206] Writing snapshot state to disk           root=28fb26..40a768
INFO [01-28|18:55:56.206] Persisted trie from memory database      nodes=0    flushnodes=0 size=0.00B     flushsize=0.00B time=821ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=0    livesize=0.00B
INFO [01-28|18:55:56.207] Blockchain stopped

TestVersion40

Stack Traces | 6.690s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [01-28|18:55:49.534] Imported new potential chain segment     number=27  hash=674180..122b7e blocks=1  txs=1   mgas=7.089  elapsed=26.477ms     mgasps=267.717  triediffs=132.72KiB  triedirty=0.00B
    precompile_inclusion_test.go:94: goroutine 610792 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.6/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4093eb0, 0xc04097b180}, {0x4050c80, 0xc1495fa9f0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc04097b180, {0x4050c80, 0xc1495fa9f0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2049 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc04097b180, 0x28, {0xc1ccfebdf8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:94 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc04097b180?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc04097b180, 0x3cd2320)
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
INFO [01-28|18:55:56.206] Imported new potential chain segment     number=461 hash=803043..74f107 blocks=1  txs=1   mgas=0.154  elapsed=7.030ms      mgasps=21.896   triediffs=1.40MiB    triedirty=346.98KiB
--- FAIL: TestVersion40 (6.69s)

TestAnyTrustRekey

Stack Traces | 26.380s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [01-28|18:57:49.268] Data poster transactions confirmed       previousNonce=0 newNonce=2 previousL1Block=0 newL1Block=68
WARN [01-28|18:57:49.333] Served eth_sendRawTransaction            reqid=5   duration=27.280139ms  err="nonce too low: address 0x26E554a8acF9003b83495c7f45F06edCB803d4e3, tx: 1 state: 2"
    common_test.go:918: goroutine 14 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.6/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x438eab0, 0xc00010b340}, {0x434aea0, 0xc0aacabb00}, {0xc11bc817e0, 0x1, 0x1})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/system_tests.Require(0xc00010b340, {0x434aea0, 0xc0aacabb00}, {0xc11bc817e0, 0x1, 0x1})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2049 +0x5d
        github.com/offchainlabs/nitro/system_tests.(*NodeBuilder).BuildL2OnL1(0xc0005c1320, 0xc00010b340)
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:918 +0x5ae
        github.com/offchainlabs/nitro/system_tests.TestAnyTrustRekey(0xc00010b340)
        	/home/runner/work/nitro/nitro/system_tests/anytrust_test.go:162 +0xeaa
        testing.tRunner(0xc00010b340, 0x3fc9f08)
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1997 +0x465
        
    common_test.go:918: �[31;1m [failed to deploy ArbDebug] nonce too low: address 0x26E554a8acF9003b83495c7f45F06edCB803d4e3, tx: 1 state: 2 �[0;0m
--- FAIL: TestAnyTrustRekey (26.38s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov