resolve small PR review comments for stylus merge on activate

[KolbyML]

resolves NIT-4406

pulls in OffchainLabs/go-ethereum#614

[codecov]

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.93%. Comparing base (efc1cdb) to head (228b42d).

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4287       +/-   ##
===========================================
+ Coverage   33.04%   56.93%   +23.89%     
===========================================
  Files         482      482               
  Lines       57028    57029        +1     
===========================================
+ Hits        18843    32468    +13625     
+ Misses      34778    19693    -15085     
- Partials     3407     4868     +1461     

[github-actions]

❌ 2 Tests Failed:

Tests completed	Failed	Passed	Skipped
4047	2	4045	0

View the top 2 failed tests by shortest run time

TestNitroNodeVersionAlerter

Stack Traces | 0.270s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [01-28|22:32:52.602] Persisting dirty state                   head=35  root=6ad4dd..09230d layers=35
INFO [01-28|22:32:52.603] Starting work on payload                 id=0x034bdb72e0dc71f6
INFO [01-28|22:32:52.602] Blockchain stopped
INFO [01-28|22:32:52.604] Updated payload                          id=0x034bdb72e0dc71f6 number=12   hash=c22df5..65297c txs=1   withdrawals=0 gas=1,573,632  fees=1.573632e-06   root=dc9832..6ad00a elapsed="660.84µs"
INFO [01-28|22:32:52.604] Stopping work on payload                 id=0x034bdb72e0dc71f6 reason=delivery
INFO [01-28|22:32:52.605] Persisted dirty state to disk            size=168.45KiB elapsed=2.565ms
INFO [01-28|22:32:52.605] Imported new potential chain segment     number=12   hash=c22df5..65297c blocks=1  txs=1   mgas=1.574  elapsed=1.067ms      mgasps=1474.300 triediffs=38.82KiB   triedirty=0.00B
INFO [01-28|22:32:52.605] Submitted contract creation              hash=0xe1bff290ff93cd5a45bca5b504e58020051df1843faa4e668343d23305083234 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=12   contract=0x13336A35bDbf0B32b3Db83dc1f76dCc33eDAbDc7 value=0
INFO [01-28|22:32:52.605] Blockchain stopped
INFO [01-28|22:32:52.605] Chain head was updated                   number=12   hash=c22df5..65297c root=dc9832..6ad00a elapsed="267.228µs"
INFO [01-28|22:32:52.606] New Key                                  name=Faucet            Address=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A
INFO [01-28|22:32:52.606] New Key                                  name=RollupOwner       Address=0x57Ff0F473737a1c161bfF9efDF016F7991585088
INFO [01-28|22:32:52.606] New Key                                  name=Sequencer         Address=0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23
INFO [01-28|22:32:52.607] New Key                                  name=Validator         Address=0x83FFCFaCE2Fb0E1286686815503608A16EF41e47
INFO [01-28|22:32:52.607] New Key                                  name=User              Address=0x7E23C8862920797d81916d62c274dd9217113e28
INFO [01-28|22:32:52.607] Starting work on payload                 id=0x03b6b646ebb1a6e2
INFO [01-28|22:32:52.607] Allocated trie memory caches             clean=154.00MiB dirty=256.00MiB
INFO [01-28|22:32:52.607] State schema set to default              scheme=path
WARN [01-28|22:32:52.608] Head block is not reachable
--- FAIL: TestNitroNodeVersionAlerter (0.27s)

TestOutOfGasInStorageCacheFlush

Stack Traces | 34.960s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [01-28|22:31:59.364] New Key                                  name=RollupOwner       Address=0x57Ff0F473737a1c161bfF9efDF016F7991585088
INFO [01-28|22:31:59.364] New Key                                  name=Sequencer         Address=0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23
INFO [01-28|22:31:59.364] New Key                                  name=Validator         Address=0x83FFCFaCE2Fb0E1286686815503608A16EF41e47
INFO [01-28|22:31:59.364] New Key                                  name=User              Address=0x7E23C8862920797d81916d62c274dd9217113e28
INFO [01-28|22:31:59.365] Allocated trie memory caches             clean=154.00MiB dirty=256.00MiB
INFO [01-28|22:31:59.365] State schema set to default              scheme=path
WARN [01-28|22:31:59.365] Head block is not reachable
INFO [01-28|22:31:59.366] Initialising Ethereum protocol           network=412,346 dbversion=<nil>
INFO [01-28|22:31:59.366] Load database journal from disk
INFO [01-28|22:31:59.366] State snapshot generator is not found
INFO [01-28|22:31:59.366] Starting snapshot generation             root=56e81f..63b421 accounts=0  slots=0  storage=0.00B   dangling=0 elapsed="2.164µs"
INFO [01-28|22:31:59.367] Initialized path database                triecache=154.00MiB statecache=102.00MiB buffer=256.00MiB state-history="last 90000 blocks"
INFO [01-28|22:31:59.367] Writing custom genesis block
INFO [01-28|22:31:59.367] Resuming snapshot generation             root=56e81f..63b421 accounts=0  slots=0  storage=0.00B   dangling=0 elapsed="418.01µs"
INFO [01-28|22:31:59.367] Generated snapshot                       accounts=0  slots=0  storage=0.00B   dangling=0 elapsed="491.808µs"
--- FAIL: TestOutOfGasInStorageCacheFlush (34.96s)
INFO [01-28|22:31:59.780] Submitted transaction                    hash=0x330f9db81ecb11bc8367a5fc35e4b7c82d114fd8b2317d0431981378ba0e7aa8 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=308 recipient=0x7E23C8862920797d81916d62c274dd9217113e28 value=1,000,000,000,000
INFO [01-28|22:31:59.781] Starting work on payload                 id=0x03bb27adc7fad371
INFO [01-28|22:31:59.784] New Key                                  name=Faucet            Address=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A
INFO [01-28|22:31:59.784] New Key                                  name=RollupOwner       Address=0x57Ff0F473737a1c161bfF9efDF016F7991585088

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov