Introduce genesis-json-file-directory config option #4291

amsanghi · 2026-01-29T12:41:45Z

codecov · 2026-01-29T12:59:25Z

Codecov Report

❌ Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.10%. Comparing base (1610629) to head (48bdb44).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4291      +/-   ##
==========================================
+ Coverage   32.86%   33.10%   +0.24%     
==========================================
  Files         489      489              
  Lines       57967    58002      +35     
==========================================
+ Hits        19051    19203     +152     
+ Misses      35580    35425     -155     
- Partials     3336     3374      +38

github-actions · 2026-01-29T14:25:32Z

❌ 5 Tests Failed:

Tests completed	Failed	Passed	Skipped
4193	5	4188	0

View the top 3 failed tests by shortest run time

TestVersion40

Stack Traces | 5.160s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc02b62aa80?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc02b62aa80, 0x3d1f1b0)
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
INFO [02-11|00:53:23.418] Submitted contract creation              hash=0x1ac429312859918f4b90cafc2104f78ba3f620f051d2fc4b96e2ac2090eccad8 from=0x57Ff0F473737a1c161bfF9efDF016F7991585088 nonce=21   contract=0x5E6d7135B0a5F12bF935A83B7d5b5e4a8BFf112d value=0
INFO [02-11|00:53:23.419] Starting work on payload                 id=0x03fe8429cbe8596d
INFO [02-11|00:53:23.420] Writing cached state to disk             block=1   hash=fcadfd..7b7434 root=9d2e2f..b7db94
INFO [02-11|00:53:23.420] Persisted trie from memory database      nodes=23   flushnodes=0 size=3.61KiB   flushsize=0.00B time="120.294µs"  flushtime=0s gcnodes=0 gcsize=0.00B gctime="1.463µs"  livenodes=0    livesize=0.00B
INFO [02-11|00:53:23.420] Writing cached state to disk             block=1   hash=fcadfd..7b7434 root=9d2e2f..b7db94
INFO [02-11|00:53:23.420] Persisted trie from memory database      nodes=0    flushnodes=0 size=0.00B     flushsize=0.00B time="1.102µs"    flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=0    livesize=0.00B
INFO [02-11|00:53:23.420] Writing snapshot state to disk           root=930b37..bec76f
INFO [02-11|00:53:23.420] Persisted trie from memory database      nodes=0    flushnodes=0 size=0.00B     flushsize=0.00B time=501ns        flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=0    livesize=0.00B
INFO [02-11|00:53:23.420] Blockchain stopped
INFO [02-11|00:53:23.421] Updated payload                          id=0x03fe8429cbe8596d number=25   hash=3e393b..6aedb3 txs=1   withdrawals=0 gas=3,088,290  fees=3.08829e-06    root=bfb069..6cb8f0 elapsed=1.187ms
INFO [02-11|00:53:23.421] Stopping work on payload                 id=0x03fe8429cbe8596d reason=delivery
--- FAIL: TestVersion40 (5.16s)

TestAuctioneerRecoversBidsOnRestart

Stack Traces | 19.090s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [02-11|00:44:28.553] Stopping work on payload                 id=0x03e16dedf2cd5437                      reason=delivery
INFO [02-11|00:44:28.553] Imported new potential chain segment     number=23 hash=b9040d..d6c980 blocks=1 txs=0 mgas=0.000 elapsed="151.07µs"  mgasps=0.000    triediffs=38.86KiB triedirty=0.00B
INFO [02-11|00:44:28.553] Chain head was updated                   number=23 hash=b9040d..d6c980 root=635bde..a41955 elapsed="27.454µs"
INFO [02-11|00:44:28.628] Submitted transaction                    hash=0x77ea222727daedaa88a9005bd07a6abd5391c8c74d0f610f038a8e5b6f215d32 from=0xAFD7d9eEF2fDC8FB26f5444250279A8a81e19570 nonce=2  recipient=0xD2a149B70cFC4bd677347e21CE2ca424EfA4aB28 value=0
INFO [02-11|00:44:28.631] Submitted transaction                    hash=0xf2195b9b06f758c6dece4cb47c3646373df04a2aec1d0821f54d2afe0129a139 from=0x283c000098B5cc92DE4b96f0c0b31eE29AE646fC nonce=2  recipient=0x41708d5c46094EF6C768Fb1AFa959b3C7EEA94b2 value=0
INFO [02-11|00:44:29.549] Starting work on payload                 id=0x03e58cf578f63833
INFO [02-11|00:44:29.549] Updated payload                          id=0x03e58cf578f63833                      number=24 hash=53913f..744edc txs=1 withdrawals=0 gas=91929     fees=9.1929e-08   root=09b19d..adeb99 elapsed="355.664µs"
INFO [02-11|00:44:29.549] Stopping work on payload                 id=0x03e58cf578f63833                      reason=delivery
INFO [02-11|00:44:29.550] Imported new potential chain segment     number=24 hash=53913f..744edc blocks=1 txs=1 mgas=0.092 elapsed="524.732µs" mgasps=175.192  triediffs=60.89KiB triedirty=0.00B
INFO [02-11|00:44:29.550] Chain head was updated                   number=24 hash=53913f..744edc root=09b19d..adeb99 elapsed="38.883µs"
INFO [02-11|00:44:29.552] Starting work on payload                 id=0x039b9d472a879dcd
INFO [02-11|00:44:29.552] Updated payload                          id=0x039b9d472a879dcd                      number=24 hash=1793ec..5bce94 txs=1 withdrawals=0 gas=91929     fees=9.1929e-08   root=664b24..ffb33b elapsed="404.759µs"
INFO [02-11|00:44:29.552] Stopping work on payload                 id=0x039b9d472a879dcd                      reason=delivery
INFO [02-11|00:44:29.553] Imported new potential chain segment     number=24 hash=1793ec..5bce94 blocks=1 txs=1 mgas=0.092 elapsed="545.125µs" mgasps=168.638  triediffs=62.99KiB triedirty=0.00B
INFO [02-11|00:44:29.553] Starting work on payload                 id=0x03de3adc682f2638
INFO [02-11|00:44:29.553] Chain head was updated                   number=24 hash=1793ec..5bce94 root=664b24..ffb33b elapsed="35.046µs"
INFO [02-11|00:44:29.553] Updated payload                          id=0x03de3adc682f2638                      number=24 hash=cb6908..854a02 txs=0 withdrawals=0 gas=0         fees=0            root=635bde..a41955 elapsed="59.061µs"
INFO [02-11|00:44:29.553] Stopping work on payload                 id=0x03de3adc682f2638                      reason=delivery
INFO [02-11|00:44:29.553] Imported new potential chain segment     number=24 hash=cb6908..854a02 blocks=1 txs=0 mgas=0.000 elapsed="195.639µs" mgasps=0.000    triediffs=38.86KiB triedirty=0.00B
INFO [02-11|00:44:29.553] Chain head was updated                   number=24 hash=cb6908..854a02 root=635bde..a41955 elapsed="27.001µs"

TestSequencerPriceAdjustsFrom5Gwei

Stack Traces | 21.640s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [02-11|00:56:56.042] Submitted transaction                    hash=0x1ad7e67dec4750d0bca6304dcaec524e3858bf1f15da03599d51f4626261ab06 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=12 recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1,000,000,000,000
INFO [02-11|00:56:56.045] Starting work on payload                 id=0x031ebd60b3c31dea
INFO [02-11|00:56:56.046] Updated payload                          id=0x031ebd60b3c31dea number=53 hash=927a82..269832 txs=1  withdrawals=0 gas=21000     fees=0.002096824248 root=0aa27c..cb4035 elapsed=1.204ms
INFO [02-11|00:56:56.047] Stopping work on payload                 id=0x031ebd60b3c31dea reason=delivery
INFO [02-11|00:56:56.048] Imported new potential chain segment     number=53 hash=927a82..269832 blocks=1  txs=1  mgas=0.021 elapsed=2.089ms      mgasps=10.049   triediffs=243.69KiB triedirty=0.00B
INFO [02-11|00:56:56.049] Chain head was updated                   number=53 hash=927a82..269832 root=0aa27c..cb4035 elapsed="80.25µs"
INFO [02-11|00:56:56.051] Submitted transaction                    hash=0x9349503ebfa05942d95c9c85b7872edc2eb012d041775ebe6ffe55e7d11b1f3d from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=15 recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1,000,000,000,000
INFO [02-11|00:56:56.053] Starting work on payload                 id=0x0372e760eac0f3aa
INFO [02-11|00:56:56.054] Updated payload                          id=0x0372e760eac0f3aa number=51 hash=79e1e7..13bbcd txs=1  withdrawals=0 gas=21000     fees=0.002095851771 root=df88e1..6d59c6 elapsed=1.282ms
INFO [02-11|00:56:56.056] Stopping work on payload                 id=0x0372e760eac0f3aa reason=delivery
INFO [02-11|00:56:56.057] Imported new potential chain segment     number=51 hash=79e1e7..13bbcd blocks=1  txs=1  mgas=0.021 elapsed=1.905ms      mgasps=11.019   triediffs=237.25KiB triedirty=0.00B
INFO [02-11|00:56:56.057] Chain head was updated                   number=51 hash=79e1e7..13bbcd root=df88e1..6d59c6 elapsed="89.788µs"
INFO [02-11|00:56:56.058] Submitted transaction                    hash=0x4d6064e44c7537bf33cf00d602fad132637ea9f1a2c03b60004b0ee87265d2db from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=7  recipient=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A value=1,000,000,000,000
INFO [02-11|00:56:56.060] Persisting dirty state                   head=22 root=3d995e..18fadb layers=22
INFO [02-11|00:56:56.060] Starting work on payload                 id=0x032caa626b478071
INFO [02-11|00:56:56.061] Updated payload                          id=0x032caa626b478071 number=43 hash=39bc4b..7ef7e6 txs=1  withdrawals=0 gas=21000     fees=0.002087959016 root=965318..3f682a elapsed="925.571µs"
INFO [02-11|00:56:56.062] Stopping work on payload                 id=0x032caa626b478071 reason=delivery
INFO [02-11|00:56:56.063] Imported new potential chain segment     number=43 hash=39bc4b..7ef7e6 blocks=1  txs=1  mgas=0.021 elapsed=1.561ms      mgasps=13.452   triediffs=205.16KiB triedirty=0.00B
INFO [02-11|00:56:56.064] Chain head was updated                   number=43 hash=39bc4b..7ef7e6 root=965318..3f682a elapsed="235.261µs"
--- FAIL: TestSequencerPriceAdjustsFrom5Gwei (21.64s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

ganeshvanahalli

LGTM

cmd/nitro/nitro.go

tsahee

tiny change.
Generally very good and very close.
Thanks!

cmd/nitro/init/init.go

tsahee

LGTM

Introduce genesis-json-file-directory config option

9d0c7a0

amsanghi requested a review from ganeshvanahalli January 29, 2026 12:42

amsanghi assigned ganeshvanahalli Jan 29, 2026

ganeshvanahalli previously approved these changes Jan 29, 2026

View reviewed changes

ganeshvanahalli assigned amsanghi and unassigned ganeshvanahalli Jan 29, 2026

Merge branch 'master' into genesis_json_directory

b44b135

amsanghi assigned tsahee Feb 2, 2026

amsanghi requested a review from tsahee February 2, 2026 11:03

amsanghi removed their assignment Feb 2, 2026

Update changelog

91f328b

amsanghi dismissed ganeshvanahalli’s stale review via 91f328b February 3, 2026 15:04

tsahee requested changes Feb 5, 2026

View reviewed changes

cmd/nitro/nitro.go Outdated Show resolved Hide resolved

cmd/nitro/nitro.go Outdated Show resolved Hide resolved

tsahee assigned amsanghi and unassigned tsahee Feb 5, 2026

amsanghi and others added 3 commits February 5, 2026 14:20

Changes based on PR comments

c103182

minor fix

7dd913e

Merge branch 'master' into genesis_json_directory

464e292

amsanghi requested a review from tsahee February 5, 2026 09:10

amsanghi assigned tsahee and unassigned amsanghi Feb 5, 2026

tsahee requested changes Feb 9, 2026

View reviewed changes

cmd/nitro/nitro.go Outdated Show resolved Hide resolved

tsahee assigned amsanghi and unassigned tsahee Feb 9, 2026

amsanghi added 2 commits February 10, 2026 21:37

Changes based on PR comments

61946b7

Merge branch 'master' into genesis_json_directory

f154489

amsanghi requested a review from tsahee February 10, 2026 16:13

amsanghi assigned tsahee Feb 10, 2026

amsanghi removed their assignment Feb 10, 2026

minor fix

f63aa9d

tsahee requested changes Feb 10, 2026

View reviewed changes

cmd/nitro/init/init.go Outdated Show resolved Hide resolved

tsahee assigned amsanghi and unassigned tsahee Feb 10, 2026

amsanghi and others added 2 commits February 11, 2026 06:01

Changes based on PR comments

56a64ff

Merge branch 'master' into genesis_json_directory

48bdb44

amsanghi requested a review from tsahee February 11, 2026 00:31

amsanghi assigned tsahee and unassigned amsanghi Feb 11, 2026

tsahee assigned joshuacolvin0 and unassigned tsahee Feb 11, 2026

tsahee approved these changes Feb 11, 2026

View reviewed changes

joshuacolvin0 added the design-approved label Feb 11, 2026

joshuacolvin0 added this pull request to the merge queue Feb 11, 2026

Merged via the queue into master with commit 466533d Feb 11, 2026
26 checks passed

joshuacolvin0 deleted the genesis_json_directory branch February 11, 2026 04:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce genesis-json-file-directory config option #4291

Introduce genesis-json-file-directory config option #4291

amsanghi commented Jan 29, 2026

Uh oh!

codecov bot commented Jan 29, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 29, 2026 •

edited

Loading

Uh oh!

ganeshvanahalli left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tsahee left a comment

Uh oh!

Uh oh!

tsahee left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Introduce genesis-json-file-directory config option #4291

Introduce genesis-json-file-directory config option #4291

Conversation

amsanghi commented Jan 29, 2026

Uh oh!

codecov bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 5 Tests Failed:

Uh oh!

ganeshvanahalli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tsahee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tsahee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 29, 2026 •

edited

Loading

github-actions bot commented Jan 29, 2026 •

edited

Loading