-
Notifications
You must be signed in to change notification settings - Fork 710
[MEL] - Enable Block Validation with MEL Support #4338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: mel-validator-createvalidationentry
Are you sure you want to change the base?
[MEL] - Enable Block Validation with MEL Support #4338
Conversation
…k-validator-enabled
…nLabs/nitro into raul/mel-block-validator-enabled
❌ 49 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
…ockvalidation Make L2-message preimages recorded by MEL validator available to block validator
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## mel-validator-createvalidationentry #4338 +/- ##
=======================================================================
+ Coverage 28.46% 29.02% +0.56%
=======================================================================
Files 495 497 +2
Lines 58271 58784 +513
=======================================================================
+ Hits 16585 17064 +479
+ Misses 38662 38625 -37
- Partials 3024 3095 +71 |
staker/mel_validator.go
Outdated
| }, | ||
| EndParentChainBlockHash: endState.ParentChainBlockHash, | ||
| }, 0, nil | ||
| }, currentState, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt this be endState instead of currentState?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be the same but edited for correctness
This PR completes the new, unified replay binary used by Nitro that can perform both message extraction and block execution. It also ties MEL into the block validator so that the block validator can operate over messages extracted by MEL. With MEL-enabled, the block validator's responsibility becomes quite simple: it simply asks for the latest MEL state that was validated, and schedules an Arbitrator execution run over a message. This PR adds a new
MEL-Enabled Validation Entry Creatorwhich contains the logic to deal with MEL in the block validator. This requires very few other changes to the block validator.We also add a system test that does the following: