Handle roll backs in MELValidator and BlockValidator #4360
+134
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## raul/mel-block-validator-enabled #4360 +/- ##
====================================================================
- Coverage 28.96% 28.95% -0.02%
====================================================================
Files 497 497
Lines 58774 58835 +61
====================================================================
+ Hits 17022 17033 +11
- Misses 38647 38701 +54
+ Partials 3105 3101 -4 |
Contributor
❌ 55 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
rauljordan
requested changes
Feb 11, 2026
arbnode/mel/runner/mel.go
Outdated
| } | ||
|
|
||
| type MELValidator interface { | ||
| Rewind(parentChainBlockNumber uint64) |
Contributor
There was a problem hiding this comment.
Is this the parent chain block number we want to rewind to?
arbnode/mel/runner/mel.go
Outdated
| return err | ||
| } | ||
| if m.melValidator != nil { | ||
| m.melValidator.Rewind(parentChainBlockNumber) |
Contributor
There was a problem hiding this comment.
This introduces a circular dependency. It would be more idiomatic if the mel validator can subscribe to a channel and we send over that channel to anyone that cares about rewinding. That way, the runner does not need to know anything about validation
Contributor
Author
There was a problem hiding this comment.
makes sense, I added this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds required code to handle the rollbacks in MEL and Block validators during a reorg (L1 or L2 or both). Whenever a reorg is detected MELValidator (if) is rollbacked first and then the BlockValidator (if).
Resolves NIT-4480