Earliest Available Slot metrics #16069
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
reviewed
Nov 28, 2025
beacon-chain/custody/metrics.go
Outdated
| var ( | ||
| // EarliestAvailableSlotP2P tracks the earliest available slot in the p2p service | ||
| EarliestAvailableSlotP2P = promauto.NewGauge(prometheus.GaugeOpts{ | ||
| Name: "custody_earliest_available_slot_p2p", |
Contributor
There was a problem hiding this comment.
Why not just earlied_available_slot_p2p?
nalepae
reviewed
Nov 28, 2025
beacon-chain/custody/metrics.go
Outdated
| // EarliestAvailableSlotP2P tracks the earliest available slot in the p2p service | ||
| EarliestAvailableSlotP2P = promauto.NewGauge(prometheus.GaugeOpts{ | ||
| Name: "custody_earliest_available_slot_p2p", | ||
| Help: "The earliest available slot tracked by the p2p service for custody purposes", |
nalepae
reviewed
Nov 28, 2025
beacon-chain/custody/metrics.go
Outdated
|
|
||
| // EarliestAvailableSlotDB tracks the earliest available slot in the database | ||
| EarliestAvailableSlotDB = promauto.NewGauge(prometheus.GaugeOpts{ | ||
| Name: "custody_earliest_available_slot_db", |
Contributor
There was a problem hiding this comment.
Why not just earliest_available_slot_db?
nalepae
reviewed
Nov 28, 2025
beacon-chain/custody/metrics.go
Outdated
| // EarliestAvailableSlotDB tracks the earliest available slot in the database | ||
| EarliestAvailableSlotDB = promauto.NewGauge(prometheus.GaugeOpts{ | ||
| Name: "custody_earliest_available_slot_db", | ||
| Help: "The earliest available slot tracked by the database for custody purposes", |
nalepae
reviewed
Nov 28, 2025
beacon-chain/custody/metrics.go
Outdated
| @@ -0,0 +1,32 @@ | |||
| // Package custody provides common custody-related metrics | |||
| package custody | |||
Contributor
There was a problem hiding this comment.
Please do not create a whole package only to add 2 metrics.
nalepae
reviewed
Nov 28, 2025
Contributor
There was a problem hiding this comment.
I did not read all the PR.
My main question is:
Why not simply update the metrics in the function actually changing the corresponding values, or when the correspond values are first pulled at the start of the node?
You can start by identifying all places where the eas is updated, then the place where eas if first pulled from the DB.
Then, just add metrics update in those places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR adds metrics for earliest available slot. Two metrics are added corresponding to the DB update and p2p update. They have been tested on kurtosis to exactly match.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements