Draft
Conversation
Contributor
|
LGTM, nit: it may be cleaner for us to encode extra data as struct and move the parsing and validation logic into dedicated method |
waelsy123
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repurpose the currently unused
dataargument ofoutboundTransferCustomRefundto allow the user to specify an optional slippage tolerance.the user has to specify the slippage as
abi.encode(0, minRecv). if we want to use the data arg for something else in the future and keep tooling forward compatible we can add other "types" in the first 32 bytes that dictate how to parse the following bytes