Do Not Merge - Python Migration Meetings App Icon Badging Sample #1692

Mohammed-MSFT · 2025-06-12T04:30:20Z

No description provided.

Copilot

Pull Request Overview

This PR introduces a Python migration of the Microsoft Teams meetings app icon badging sample, demonstrating how to utilize the targeted notifications API for app icon badging during Teams meetings. The migration creates a complete Python implementation using Bot Framework v4 SDK and aiohttp web framework.

Key changes:

Complete Python bot implementation with TeamsActivityHandler for meeting notifications
Web server setup with aiohttp for serving HTML views and handling bot messages
Teams manifest and Azure infrastructure configuration for deployment

Reviewed Changes

Copilot reviewed 23 out of 26 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
bots/teamsBot.py	Core bot implementation with meeting notification handlers for stage view and app icon badging
app.py	Main web server application using aiohttp with bot message processing and view routing
requirements.txt	Python dependencies including botbuilder SDK packages
README.md	Documentation with setup instructions and feature descriptions
appManifest/manifest.json	Teams app manifest configuration with bot and tab definitions
config.py	Bot configuration class for environment variables
Various infrastructure files	Azure deployment, VS Code settings, and environment configuration files

Copilot · 2025-07-16T04:04:16Z

samples/meetings-app-icon-badging/python/bots/__init__.py

@@ -0,0 +1,3 @@
+from .teamsBot import TeamsBot
+
+__all__ = ["MeetingContextApp"]


The all list contains 'MeetingContextApp' but the actual imported class is 'TeamsBot'. This will cause ImportError when using 'from bots import *'.

Suggested change

__all__ = ["MeetingContextApp"]

__all__ = ["TeamsBot"]

Copilot · 2025-07-16T04:04:16Z

samples/meetings-app-icon-badging/python/bots/teamsBot.py

+    async def visual_indicator(
+        self, context: TurnContext, meeting_id: str, selected_members: list[str]
+    ):
+        from botbuilder.schema.teams._models_py3 import TargetedMeetingNotification


Import statement should be moved to the top of the file rather than inside a method. This follows Python best practices and improves code readability.

Suggested change

from botbuilder.schema.teams._models_py3 import TargetedMeetingNotification

# The import for TargetedMeetingNotification has been moved to the top of the file.

Copilot · 2025-07-16T04:04:16Z

samples/meetings-app-icon-badging/python/assets/sample.json

+    "source": "officeDev",
+    "title": "Meetings-App-Icon-Badging",
+    "shortDescription": "This sample demonstrates how to utilize the targeted notifications API for app icon badging during Teams meetings.",
+    "url": "https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/meetings-app-icon-badging/nodejs",


The URL points to the nodejs version of the sample instead of the python version. This should be updated to point to the correct python sample path.

Suggested change

"url": "https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/meetings-app-icon-badging/nodejs",

"url": "https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/meetings-app-icon-badging/python",

Copilot · 2025-07-16T04:04:17Z

samples/meetings-app-icon-badging/python/README.md

+- office-365
+languages:
+- python
+title: Microsoft Teams Python Hello World Sample


The title incorrectly identifies this as a 'Hello World Sample' when it should be 'Meetings App Icon Badging Sample' to match the actual functionality.

Suggested change

title: Microsoft Teams Python Hello World Sample

title: Microsoft Teams Python Meetings App Icon Badging Sample

Copilot · 2025-07-16T04:04:17Z

samples/meetings-app-icon-badging/python/README.md

+title: Microsoft Teams Python Hello World Sample
+description: This sample demonstrates how to retrieve and display meeting context and participant details in Microsoft Teams using the bot's Meeting API.
+extensions:
+  contentType: samples
+  createdDate: 02/24/2025 10:02:21 PM
+urlFragment: officedev-microsoft-teams-samples-meetings-context-app-python
+---
+
+# Teams Meeting Context Sample Python
+
+This sample application illustrates how to display the meeting context object in a Microsoft Teams meeting tab, utilizing the bot's Meeting API to fetch participant and meeting details. Users can interact with the bot to obtain comprehensive information about participants and meeting specifics, such as start times, end times, and joining URLs, thereby enriching the collaborative experience within Teams.


The description is incorrect for this sample. It describes meeting context functionality rather than app icon badging notifications, which is the actual purpose of this sample.

Suggested change

title: Microsoft Teams Python Hello World Sample

description: This sample demonstrates how to retrieve and display meeting context and participant details in Microsoft Teams using the bot's Meeting API.

extensions:

contentType: samples

createdDate: 02/24/2025 10:02:21 PM

urlFragment: officedev-microsoft-teams-samples-meetings-context-app-python

---

# Teams Meeting Context Sample Python

This sample application illustrates how to display the meeting context object in a Microsoft Teams meeting tab, utilizing the bot's Meeting API to fetch participant and meeting details. Users can interact with the bot to obtain comprehensive information about participants and meeting specifics, such as start times, end times, and joining URLs, thereby enriching the collaborative experience within Teams.

title: Microsoft Teams Python App Icon Badging Sample

description: This sample demonstrates how to implement app icon badging notifications in Microsoft Teams using Python.

extensions:

contentType: samples

createdDate: 02/24/2025 10:02:21 PM

urlFragment: officedev-microsoft-teams-samples-meetings-context-app-python

---

# Teams App Icon Badging Sample Python

This sample application illustrates how to implement app icon badging notifications in Microsoft Teams. App icon badging provides visual indicators on the app icon to notify users of updates or actions requiring their attention, enhancing user engagement and productivity within Teams.

Copilot · 2025-07-16T04:04:17Z

samples/meetings-app-icon-badging/python/README.md

+urlFragment: officedev-microsoft-teams-samples-meetings-context-app-python
+---
+
+# Teams Meeting Context Sample Python


The heading incorrectly refers to 'Meeting Context Sample' when it should be 'Meetings App Icon Badging Sample Python' to accurately reflect the sample's functionality.

Suggested change

# Teams Meeting Context Sample Python

# Meetings App Icon Badging Sample Python

Copilot · 2025-07-16T04:04:17Z

samples/meetings-app-icon-badging/python/README.md

+
+# Teams Meeting Context Sample Python
+
+This sample application illustrates how to display the meeting context object in a Microsoft Teams meeting tab, utilizing the bot's Meeting API to fetch participant and meeting details. Users can interact with the bot to obtain comprehensive information about participants and meeting specifics, such as start times, end times, and joining URLs, thereby enriching the collaborative experience within Teams.


The description is completely incorrect for this sample. It describes meeting context functionality rather than app icon badging notifications. The description should focus on targeted notifications API and app icon badging in Teams meetings.

Suggested change

This sample application illustrates how to display the meeting context object in a Microsoft Teams meeting tab, utilizing the bot's Meeting API to fetch participant and meeting details. Users can interact with the bot to obtain comprehensive information about participants and meeting specifics, such as start times, end times, and joining URLs, thereby enriching the collaborative experience within Teams.

This sample application demonstrates how to implement app icon badging notifications and use the targeted notifications API in Microsoft Teams meetings. It showcases how to send targeted notifications to specific users or groups and update the app icon badge to reflect important updates, enhancing the user experience within Teams.

Copilot · 2025-07-16T04:04:18Z

samples/meetings-app-icon-badging/python/m365agents.yml

+version: v1.2
+
+additionalMetadata:
+  sampleTag: Microsoft-Teams-Samples:meeting-context-app-python


The sampleTag references 'meeting-context-app-python' but should reference 'meetings-app-icon-badging-python' to match the actual sample being implemented.

Suggested change

sampleTag: Microsoft-Teams-Samples:meeting-context-app-python

sampleTag: Microsoft-Teams-Samples:meetings-app-icon-badging-python

Copilot · 2025-07-16T04:04:18Z

samples/meetings-app-icon-badging/python/.vscode/extensions.json

+{
+    "recommendations": [
+        "TeamsDevApp.ms-teams-vscode-extension",
+        "ms-python.python",


[nitpick] There is a trailing comma after the last array element which is valid JSON but may cause issues with some parsers. Consider removing the trailing comma for better compatibility.

Suggested change

"ms-python.python",

"ms-python.python"

App Icon Badging Python Migration

1decd28

Mohammed-MSFT added bug Something isn't working DO NOT MERGE Do not merge the PR due to incomplete changes or feature hasn't released yet. labels Jun 12, 2025

Mohammed-MSFT added 2 commits June 18, 2025 12:42

Fetched Members and pushed Code to the PR

1d0e7ec

Removed Commented Code

7483232

Harikrishnan-MSFT requested a review from Copilot July 16, 2025 04:02

Copilot AI reviewed Jul 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Do Not Merge - Python Migration Meetings App Icon Badging Sample #1692

Do Not Merge - Python Migration Meetings App Icon Badging Sample #1692

Uh oh!

Mohammed-MSFT commented Jun 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 16, 2025

Uh oh!

Copilot AI Jul 16, 2025

Uh oh!

Copilot AI Jul 16, 2025

Uh oh!

Copilot AI Jul 16, 2025

Uh oh!

Copilot AI Jul 16, 2025

Uh oh!

Copilot AI Jul 16, 2025

Uh oh!

Copilot AI Jul 16, 2025

Uh oh!

Copilot AI Jul 16, 2025

Uh oh!

Copilot AI Jul 16, 2025

Uh oh!

Uh oh!

		@@ -0,0 +1,3 @@
		from .teamsBot import TeamsBot

		__all__ = ["MeetingContextApp"]

	from botbuilder.schema.teams._models_py3 import TargetedMeetingNotification
	# The import for TargetedMeetingNotification has been moved to the top of the file.

	"url": "https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/meetings-app-icon-badging/nodejs",
	"url": "https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/meetings-app-icon-badging/python",

	title: Microsoft Teams Python Hello World Sample
	title: Microsoft Teams Python Meetings App Icon Badging Sample

	# Teams Meeting Context Sample Python
	# Meetings App Icon Badging Sample Python


		# Teams Meeting Context Sample Python

		This sample application illustrates how to display the meeting context object in a Microsoft Teams meeting tab, utilizing the bot's Meeting API to fetch participant and meeting details. Users can interact with the bot to obtain comprehensive information about participants and meeting specifics, such as start times, end times, and joining URLs, thereby enriching the collaborative experience within Teams.

	sampleTag: Microsoft-Teams-Samples:meeting-context-app-python
	sampleTag: Microsoft-Teams-Samples:meetings-app-icon-badging-python

Do Not Merge - Python Migration Meetings App Icon Badging Sample #1692

Are you sure you want to change the base?

Do Not Merge - Python Migration Meetings App Icon Badging Sample #1692

Uh oh!

Conversation

Mohammed-MSFT commented Jun 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!