Python Migration - Bot Proactive Messaging Teamsfx #1701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Python sample for Teams proactive messaging using TeamsFx, including infrastructure as code, environment configuration, sample code, and CI workflow updates.
- Introduces a Python-based proactive messaging sample with Bicep templates and environment files
- Adds VS Code Tasks/Launch configurations and TeamsFx YAML for local debugging and provisioning
- Updates GitHub Actions to include building the new Python sample
Reviewed Changes
Copilot reviewed 30 out of 73 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/bot-proactive-messaging-teamsfx/python/requirements.txt | Python dependencies for the new sample |
| samples/bot-proactive-messaging-teamsfx/python/*.bicep | Infrastructure definitions for Azure resources |
| samples/bot-proactive-messaging-teamsfx/python/config.py | Bot configuration class |
| samples/bot-proactive-messaging-teamsfx/python/bots/* | Bot logic and conversation handling |
| samples/bot-proactive-messaging-teamsfx/python/m365agents*.yml | TeamsFx action workflows for provision/deploy/debug |
| .github/workflows/build-complete-samples.yml | CI pipeline updated to build the Python sample |
Files not reviewed (1)
- samples/bot-proactive-messaging-teamsfx/nodejs/bot/package-lock.json: Language not supported
Comments suppressed due to low confidence (3)
samples/bot-proactive-messaging-teamsfx/python/config.py:13
- [nitpick] BOT_ID duplicates APP_ID and pulls the same environment variable; consider removing BOT_ID or renaming it for clarity if it serves a different purpose.
BOT_ID = os.environ.get("MicrosoftAppId", "")
samples/bot-proactive-messaging-teamsfx/nodejs/m365agents.yml:92
- This
projectIdkey is not nested under thewriteToEnvironmentFileblock and may be in the wrong place or indentation; please verify its position or intended use.
projectId: 42cc66bd-ac62-45b5-8cdd-c6175a20be65
samples/bot-proactive-messaging-teamsfx/python/config.py:16
- [nitpick] The attribute name
APP_TENANTIDis missing an underscore for readability; consider renaming toAPP_TENANT_IDto match the style of other attributes.
APP_TENANTID = os.environ.get("MicrosoftAppTenantId", "")
samples/bot-proactive-messaging-teamsfx/python/bots/__init__.py
Outdated
Show resolved
Hide resolved
Comment on lines
11
to
12
| "creationDateTime": "2025-21-06", | ||
| "updateDateTime": "2025-21-06", |
There was a problem hiding this comment.
The date format "2025-21-06" is invalid (month 21); swap day and month to follow ISO (e.g., "2025-06-21").
Suggested change
| "creationDateTime": "2025-21-06", | |
| "updateDateTime": "2025-21-06", | |
| "creationDateTime": "2025-06-21", | |
| "updateDateTime": "2025-06-21", |
Copilot uses AI. Check for mistakes.
Pawank-MSFT
reviewed
Jul 16, 2025
samples/bot-proactive-messaging-teamsfx/python/Images/4.Welcome_Message.png
Outdated
Show resolved
Hide resolved
samples/bot-proactive-messaging-teamsfx/python/Images/5.Proactive_API_Notify.png
Outdated
Show resolved
Hide resolved
samples/bot-proactive-messaging-teamsfx/python/Images/6.Proactive_Notify_2.png
Outdated
Show resolved
Hide resolved
samples/bot-proactive-messaging-teamsfx/python/Images/7.Practive_Hello_Message.png
Outdated
Show resolved
Hide resolved
samples/bot-proactive-messaging-teamsfx/python/Images/Proactive_Messaging_TeamsFx.gif
Outdated
Show resolved
Hide resolved
Pawank-MSFT
approved these changes
Sep 2, 2025
AjayJ12-MSFT
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.