Create new samples for bot-adaptivecards-user-specific-views (Node.js) and bot-conversation-quickstart (C#) and tab-channel-group (nodejs) #1709
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This pull request implements a Node.js conversion of the C# Adaptive Card User Specific Views bot sample, expanding the Teams sample collection to include cross-platform support. The conversion demonstrates user-specific views in Adaptive Cards within Microsoft Teams using Action.Execute and auto-refresh capabilities for dynamic, personalized content.
Key Changes:
- Complete Node.js implementation of adaptive card user-specific views functionality
- Microsoft 365 Agents Toolkit integration for streamlined development workflow
- Comprehensive sample configuration and documentation for Teams development
Reviewed Changes
Copilot reviewed 72 out of 121 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| samples/tab-channel-group/nodejs/* | Complete Node.js tab implementation with React components and routing |
| samples/bot-conversation-quickstart/csharp/* | C# bot quickstart sample with M365 Agents Toolkit integration |
| samples/bot-adaptivecards-user-specific-views/nodejs/* | Node.js adaptive cards bot with user-specific view capabilities |
| README.md | Updated sample listing to include new Node.js adaptive cards implementation |
| ? "/images/IconGray.png" | ||
| : selectedColor === "red" | ||
| ? "/Images/IconRed.png" | ||
| : "/Images/TeamsIcon.png" |
There was a problem hiding this comment.
The image paths have inconsistent casing. Line 67 uses "/images/IconGray.png" while TabConfig.js uses "/images/iconGray.png" (lowercase 'i'). This inconsistency could cause broken images on case-sensitive file systems.
| ? "/images/IconGray.png" | |
| : selectedColor === "red" | |
| ? "/Images/IconRed.png" | |
| : "/Images/TeamsIcon.png" | |
| ? "/images/icongray.png" | |
| : selectedColor === "red" | |
| ? "/images/iconred.png" | |
| : "/images/teamsicon.png" |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Corrected and fixed
| selectedColor === "gray" | ||
| ? "/images/IconGray.png" | ||
| : selectedColor === "red" | ||
| ? "/Images/IconRed.png" |
There was a problem hiding this comment.
The image path uses "/Images/IconRed.png" with capital 'I' in 'Images', which is inconsistent with other references that use lowercase 'images'. This could cause broken images on case-sensitive file systems.
| ? "/Images/IconRed.png" | |
| ? "/images/IconRed.png" |
Copilot uses AI. Check for mistakes.
| ? "/Images/IconRed.png" | ||
| : "/Images/TeamsIcon.png" |
There was a problem hiding this comment.
The image path uses "/Images/TeamsIcon.png" with capital 'I' in 'Images', which is inconsistent with other references that use lowercase 'images'. This could cause broken images on case-sensitive file systems.
| ? "/Images/IconRed.png" | |
| : "/Images/TeamsIcon.png" | |
| ? "/images/IconRed.png" | |
| : "/images/TeamsIcon.png" |
Copilot uses AI. Check for mistakes.
| return ( | ||
| <div> | ||
| <h1>Success!</h1> | ||
| <img id="icon" src="/images/IconGray.png" alt="Red Image" style={{ width: "100px" }} /> |
There was a problem hiding this comment.
The alt text says "Red Image" but this is displaying a gray icon. The alt text should accurately describe the image content for accessibility.
| <img id="icon" src="/images/IconGray.png" alt="Red Image" style={{ width: "100px" }} /> | |
| <img id="icon" src="/images/IconGray.png" alt="Gray Icon" style={{ width: "100px" }} /> |
Copilot uses AI. Check for mistakes.
| const gray = "Tab.js says: 'You chose Gray!"; | ||
| const red = "Tab.js says: 'You chose Red!"; |
There was a problem hiding this comment.
The string has an unmatched single quote. It starts with a single quote but doesn't close it properly, which could lead to syntax issues.
| const gray = "Tab.js says: 'You chose Gray!"; | |
| const red = "Tab.js says: 'You chose Red!"; | |
| const gray = "Tab.js says: 'You chose Gray!'"; | |
| const red = "Tab.js says: 'You chose Red!'"; |
Copilot uses AI. Check for mistakes.
| const gray = "Tab.js says: 'You chose Gray!"; | ||
| const red = "Tab.js says: 'You chose Red!"; |
There was a problem hiding this comment.
The string has an unmatched single quote. It starts with a single quote but doesn't close it properly, which could lead to syntax issues.
| const gray = "Tab.js says: 'You chose Gray!"; | |
| const red = "Tab.js says: 'You chose Red!"; | |
| const gray = "Tab.js says: 'You chose Gray!'"; | |
| const red = "Tab.js says: 'You chose Red!'"; |
Copilot uses AI. Check for mistakes.
| import ReactDOM from 'react-dom'; | ||
| import './index.css'; | ||
| import App from './components/App'; | ||
| ReactDOM.render( | ||
|
|
||
| <App /> | ||
| , document.getElementById('root') |
There was a problem hiding this comment.
ReactDOM.render is deprecated in React 18. Consider using createRoot from 'react-dom/client' instead for better performance and future compatibility.
| import ReactDOM from 'react-dom'; | |
| import './index.css'; | |
| import App from './components/App'; | |
| ReactDOM.render( | |
| <App /> | |
| , document.getElementById('root') | |
| import { createRoot } from 'react-dom/client'; | |
| import './index.css'; | |
| import App from './components/App'; | |
| const root = createRoot(document.getElementById('root')); | |
| root.render( | |
| <App /> |
Copilot uses AI. Check for mistakes.
README.md
Outdated
There was a problem hiding this comment.
Need to add Bot-conversation-Quickstart C# and Tab-channel-group/nodejs also
| @@ -0,0 +1,114 @@ | |||
| { | |||
| "id": "08500d07-8c32-41d1-bcd9-ec5b48245744", | |||
| "appId": "aee7ddf0-6b6e-4f99-9514-0ebf3fecae7a", | |||
There was a problem hiding this comment.
Need to remove this. check all Ids. Remove build folder
Harikrishnan-MSFT
changed the title
No description provided.