Readme for the bot-proactive-messaging-teamsfx sample has been updated. #1726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README for the bot-proactive-messaging-teamsfx sample by adding metadata, reorganizing usage instructions, and including demo manifest links and images.
- Added front-matter metadata and demo manifest section
- Reorganized "Run the app" and setup instructions with clearer step-by-step guidance
- Included animated GIFs and screenshots for improved clarity
| - [NodeJS](https://nodejs.org/en/) | ||
| - An M365 account. If you do not have M365 account, apply one from [M365 developer program](https://developer.microsoft.com/en-us/microsoft-365/dev-program) | ||
| - [Microsoft 365 Agents Toolkit Visual Studio Code Extension](https://aka.ms/teams-toolkit) version after 1.55 or [Microsoft 365 Agents Toolkit CLI](https://aka.ms/teams-toolkit-cli) | ||
| This sample provides following functionality: |
There was a problem hiding this comment.
Consider adding the definite article "the": change to "This sample provides the following functionality:".
Suggested change
| This sample provides following functionality: | |
| This sample provides the following functionality: |
Copilot uses AI. Check for mistakes.
| - [Microsoft 365 Agents Toolkit Visual Studio Code Extension](https://aka.ms/teams-toolkit) version after 1.55 or [Microsoft 365 Agents Toolkit CLI](https://aka.ms/teams-toolkit-cli) | ||
| This sample provides following functionality: | ||
|
|
||
| - You can send any command to bot to get the same message echoed back. |
There was a problem hiding this comment.
Add "the" before "bot": change to "send any command to the bot".
Suggested change
| - You can send any command to bot to get the same message echoed back. | |
| - You can send any command to the bot to get the same message echoed back. |
Copilot uses AI. Check for mistakes.
| 1) __*This step is specific to Teams.*__ | ||
| - **Edit** the `manifest.json` contained in the `appManifest` folder to replace your Microsoft App Id (that was created when you registered your bot earlier) *everywhere* you see the place holder string `<<YOUR-MICROSOFT-APP-ID>>` (depending on the scenario the Microsoft App Id may occur multiple times in the `manifest.json`) | ||
| - **Edit** the `manifest.json` for `validDomains` with base Url domain. E.g. if you are using ngrok it would be `https://1234.ngrok-free.app` then your domain-name will be `1234.ngrok-free.app` and if you are using dev tunnels then your domain will be like: `12345.devtunnels.ms`. | ||
| - **Zip** up the contents of the `appManifest` folder to create a `manifest.zip` (Make sure that zip file does not contains any subfolder otherwise you will get error while uploading your .zip package) |
There was a problem hiding this comment.
Correct grammar: replace "does not contains" with "does not contain".
Suggested change
| - **Zip** up the contents of the `appManifest` folder to create a `manifest.zip` (Make sure that zip file does not contains any subfolder otherwise you will get error while uploading your .zip package) | |
| - **Zip** up the contents of the `appManifest` folder to create a `manifest.zip` (Make sure that zip file does not contain any subfolder otherwise you will get error while uploading your .zip package) |
Copilot uses AI. Check for mistakes.
|
|
||
| ## Play with the App | ||
| Message the bot and it will respond with a proactive hello. Add a message reaction to the bots response, and the bot will reply accordingly. |
There was a problem hiding this comment.
Possessive apostrophe missing: change "bots response" to "bot's response".
Suggested change
| Message the bot and it will respond with a proactive hello. Add a message reaction to the bots response, and the bot will reply accordingly. | |
| Message the bot and it will respond with a proactive hello. Add a message reaction to the bot's response, and the bot will reply accordingly. |
Copilot uses AI. Check for mistakes.
Pawank-MSFT
reviewed
Jul 16, 2025
|
|
||
| ## Edit the manifest | ||
| ## Run the app (Using Microsoft 365 Agents Toolkit for Visual Studio Code) |
There was a problem hiding this comment.
We've added this as a new item—can we format it similarly to the README of the other project?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.