Skip to content

NAA WXP sample update #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

NAA WXP sample update #976

wants to merge 14 commits into from

Conversation

mattgeim
Copy link

@mattgeim mattgeim commented Jun 2, 2025

Q A
Bug fix? yes
New feature? no
New sample? no
Related issues? didn't look

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.
Updated to re-use the same code as Outlook sample to work in WXP.

@mattgeim mattgeim requested a review from davidchesnut June 2, 2025 20:55
@AlexJerabek
Copy link
Collaborator

@mattgeim, can you merge this into main instead of dev?

@mattgeim mattgeim changed the base branch from dev to main June 2, 2025 22:22
@mattgeim
Copy link
Author

mattgeim commented Jun 2, 2025

@mattgeim, can you merge this into main instead of dev?

Done! We may need to update our template - I believe it suggests merging into dev.

Copy link
Member

@davidchesnut davidchesnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project doesn't compile for me, looks like there is a missing file.

@mattgeim mattgeim requested a review from davidchesnut June 3, 2025 19:57
@mattgeim mattgeim requested a review from davidchesnut June 20, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants