User/archiesaxena/fix stop debug error #969
Open
+23
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description:
For the Bug : https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/36076480/
Addressed the comment of this PR : #968
Root Cause
Solution
To avoid fragile prefix-based logic, the code now:
Changes
Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters)
No. The changes are internal to the uninstallWithTeams function in office-addin-dev-settings. No CLI commands, parameters, or their requirements have been modified. The function still accepts the same input (an add-in ID) and works with the same underlying atk uninstall command.
Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins)
No. The change is an internal bug fix.
Validation/testing performed:
Local Testing done via npm link.
Stop command now works for DA projects without errors or timeouts. Clean add-in un-installation when office app is closed and debug is stopped.