Skip to content

fix(large-scale-notification): replace invalid DefaultAzureCredential option with az login auth flow#1605

Closed
Copilot wants to merge 2 commits intonintan/fix-azure-credentialfrom
copilot/sub-pr-1604
Closed

fix(large-scale-notification): replace invalid DefaultAzureCredential option with az login auth flow#1605
Copilot wants to merge 2 commits intonintan/fix-azure-credentialfrom
copilot/sub-pr-1604

Conversation

Copy link
Contributor

Copilot AI commented Feb 24, 2026

requiredEnvVars is not a valid DefaultAzureCredentialOptions property, and AZURE_TOKEN_CREDENTIALS has no meaning in Azure Identity. The script silently accepted the invalid option while the README pointed users at a non-functional env var.

Changes

  • script/mockInstallationData.ts: Remove the invalid requiredEnvVars option from DefaultAzureCredential

    // before
    const credential = new DefaultAzureCredential({
      requiredEnvVars: ["AZURE_TOKEN_CREDENTIALS"],
    });
    
    // after
    const credential = new DefaultAzureCredential();
  • README.md: Replace the instruction to set AZURE_TOKEN_CREDENTIALS=dev with the correct guidance to run az login, which is the supported auth flow for DefaultAzureCredential in local/script contexts


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…ns to use az login

Co-authored-by: tecton <886116+tecton@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 24, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • learn.microsoft.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback on default Azure credential usage fix fix(large-scale-notification): replace invalid DefaultAzureCredential option with az login auth flow Feb 24, 2026
Copilot AI requested a review from tecton February 24, 2026 03:50
@tecton tecton closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants