Skip to content

feat: move adding agent owner to collaborator #14384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

tecton
Copy link
Contributor

@tecton tecton commented Aug 4, 2025

  1. Move "Add agent owner" from "Share" to "Collaborator".
  2. Add the feature to let user list agent owner list.

Task: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/33835755
Follow: #14342

Changed UI:

  • No "share ownership with users" option when user clicks "Share".
image * Add a new option "Agent" when user chooses to "Add App Owners" or "List App Owners". (controlled by feature flag) image

CLI:
add parameter "agent" when SHARE feature flag is on.
atk collaborator grant --agent true
atk collaborator status --agent true

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 92.65537% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (4cfade7) to head (cbda936).
⚠️ Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
packages/fx-core/src/question/collaborator.ts 87.93% 0 Missing and 7 partials ⚠️
...ackages/cli/src/commands/models/permissionGrant.ts 77.77% 0 Missing and 2 partials ⚠️
packages/fx-core/src/core/collaborator.ts 94.11% 0 Missing and 2 partials ⚠️
...ckages/cli/src/commands/models/permissionStatus.ts 83.33% 0 Missing and 1 partial ⚠️
packages/fx-core/src/client/graphClient.ts 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #14384      +/-   ##
==========================================
+ Coverage   90.03%   90.06%   +0.03%     
==========================================
  Files         650      651       +1     
  Lines       38916    39001      +85     
  Branches     7800     7847      +47     
==========================================
+ Hits        35039    35128      +89     
+ Misses       1758     1753       -5     
- Partials     2119     2120       +1     
Files with missing lines Coverage Δ
packages/cli/src/commands/models/root.ts 94.73% <100.00%> (ø)
packages/cli/src/commands/models/share.ts 100.00% <ø> (ø)
packages/fx-core/src/common/constants.ts 94.33% <100.00%> (+0.10%) ⬆️
packages/fx-core/src/common/permissionInterface.ts 100.00% <ø> (ø)
...ges/fx-core/src/component/feature/collaboration.ts 91.53% <100.00%> (+2.87%) ⬆️
...kages/fx-core/src/component/m365/packageService.ts 90.39% <100.00%> (+0.02%) ⬆️
packages/fx-core/src/core/FxCore.ts 90.00% <ø> (+0.25%) ⬆️
packages/fx-core/src/question/index.ts 98.50% <100.00%> (+0.02%) ⬆️
...kages/fx-core/src/question/options/ShareOptions.ts 100.00% <ø> (ø)
packages/fx-core/src/question/other.ts 91.16% <100.00%> (+0.73%) ⬆️
... and 6 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

supkasar
supkasar previously approved these changes Aug 5, 2025
@tecton tecton marked this pull request as draft August 6, 2025 01:53
@tecton tecton marked this pull request as ready for review August 6, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants