Skip to content

Remove max url length from authenticate flow #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jekloudaMSFT
Copy link
Contributor

@jekloudaMSFT jekloudaMSFT commented Jun 20, 2025

For more information about how to contribute to this repo, visit this page.

Description

This PR removes the max length validation from the authentication.authenticate and externalAppAuthentication flows. This will resolve the issue reported in MicrosoftDocs/msteams-docs#13041. URLs that exceed the browser's URL size limit will be handled by the browser.

Main changes in the PR:

  1. Remove max URL length validation from the validateUrl util.

Validation

Validation performed:

  1. Unit tests added

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

Yes

End-to-end tests added:

N/A

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

Yes

@jekloudaMSFT jekloudaMSFT requested a review from a team as a code owner June 20, 2025 21:06
Copy link
Contributor

github-actions bot commented Jun 20, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/teams-js/dist/esm/packages/teams-js/src/index.js 190.5 KB (-0.05% 🔽) 3.9 s (-0.05% 🔽) 2.2 s (+5.68% 🔺) 6 s

Copy link
Contributor

@ndangudubiyyam ndangudubiyyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants