-
Notifications
You must be signed in to change notification settings - Fork 204
Add shortcutRelay capability to support host shortcut in Apps #2868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
39ced9b
to
1eb35d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
I think the only thing that would be missing is adding the capability to the test app, you can just use the existing code for other services. And adding the event for updating the shortcuts but not sure if you want to keep this for a PR after this one.
@juanscr is it better to add test together or separately? If there's no difference, I can do it in a follow up PR. I remember we talked about running integration tests with test apps after teams-js changes, and at the same time as making changes in the hub, but I might be mistaken. I've confirmed locally that these changes work as expected by testing them in the copilot app, after replacing node_modules/teams-js with my updates. |
Yeah this is fine, eventually we have to add E2E tests but that would usually come in an effort afterwards so we can do it in a later pR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job!
Description
Add
shortcutRelay
capability to support host shortcut in Apps.Please see detailed design in #2867