Skip to content

Add shortcutRelay capability to support host shortcut in Apps #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

YuanboXue-Amber
Copy link

@YuanboXue-Amber YuanboXue-Amber commented Aug 1, 2025

Description

Add shortcutRelay capability to support host shortcut in Apps.

Please see detailed design in #2867

@YuanboXue-Amber YuanboXue-Amber changed the title [Draft] Support Teams Shortcuts in Apps Add shortcutRelay capability to support host shortcut in Apps Aug 6, 2025
@YuanboXue-Amber YuanboXue-Amber marked this pull request as ready for review August 6, 2025 15:13
@YuanboXue-Amber YuanboXue-Amber requested a review from a team as a code owner August 6, 2025 15:13
Copy link
Contributor

@juanscr juanscr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

I think the only thing that would be missing is adding the capability to the test app, you can just use the existing code for other services. And adding the event for updating the shortcuts but not sure if you want to keep this for a PR after this one.

@YuanboXue-Amber
Copy link
Author

Good job!

I think the only thing that would be missing is adding the capability to the test app, you can just use the existing code for other services. And adding the event for updating the shortcuts but not sure if you want to keep this for a PR after this one.

@juanscr is it better to add test together or separately? If there's no difference, I can do it in a follow up PR.

I remember we talked about running integration tests with test apps after teams-js changes, and at the same time as making changes in the hub, but I might be mistaken.

I've confirmed locally that these changes work as expected by testing them in the copilot app, after replacing node_modules/teams-js with my updates.

@juanscr
Copy link
Contributor

juanscr commented Aug 6, 2025

Good job!
I think the only thing that would be missing is adding the capability to the test app, you can just use the existing code for other services. And adding the event for updating the shortcuts but not sure if you want to keep this for a PR after this one.

@juanscr is it better to add test together or separately? If there's no difference, I can do it in a follow up PR.

I remember we talked about running integration tests with test apps after teams-js changes, and at the same time as making changes in the hub, but I might be mistaken.

I've confirmed locally that these changes work as expected by testing them in the copilot app, after replacing node_modules/teams-js with my updates.

Yeah this is fine, eventually we have to add E2E tests but that would usually come in an effort afterwards so we can do it in a later pR.

Copy link
Contributor

@juanscr juanscr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants