Skip to content

[tools] (Reference Coverage) Add a JSON file to manually override coverage goals #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlexJerabek
Copy link
Contributor

Based on feedback from @samantharamon.

Methods like this are counted as needing sample coverage for our metrics but shouldn't be. This PR adds a file to manually override any coverage data for a class/interface/enum. The field count exists to serve as a reset: if the field count is different when running the coverage measurement script, the override won't happen. This means that if API are added to the class in question, it will be measured again.

Copy link
Contributor

Learn Build status updates of commit 606de23:

✅ Validation status: passed

File Status Preview URL Details
generate-docs/coverage-report-exemptions.json ✅Succeeded

For more details, please refer to the build report.

Copy link
Contributor

@ElizabethSamuel-MSFT ElizabethSamuel-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious - why is an internal member publicly documented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants