Set math.randomseed before generating sponsor message
#754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in the docstring to `nfnl.core/rand`: > You must have a random seed set before running this: > `(math.randomseed (os.time))` At present, Conjure does not do this and as a result the sponsor message is not selecting a random sponsor (unless the user happens to call `math.randomseed` within their Neovim environment). This commit adds the call recommended in the docstring.
Owner
|
I've thought about this a few times, my only concern is what if someone wants to set their own random seed for some other thing, I worry this will conflict or need configuring. But maybe until that happens, we just do this and see if there's any issues. I'll take a look and merge over this weekend, thank you! |
Olical
approved these changes
Jan 18, 2026
Owner
Olical
left a comment
Olical
left a comment
There was a problem hiding this comment.
Yeah, I'm okay with it, if people have issues with other tools we can always add config for this, but I suspect it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the docstring to
nfnl.core/rand:At present, Conjure does not do this and as a result the sponsor message is not selecting a random sponsor (unless the user happens to call
math.randomseedwithin their Neovim environment).This commit adds the call recommended in the docstring.