Skip to content

Conversation

@janis-veinbergs
Copy link

The adal (and msal) doesn't support ROPC flow with confidential client https://learn.microsoft.com/en-us/azure/active-directory/develop/v2-oauth-ropc

As part of not recommending this flow for use, the official SDKs do not support this
flow for confidential clients, those that use a secret or assertion.
You may find that the SDK you wish to use does not allow you to add a secret while using ROPC.

Unfortunately for OnPrem we don't have other client authentication flow available

Anyways, was just experimenting on what authentication flows are available to be configured for OnPrem ADFS and whether adal/msal support any of those scenarios... well, not directly, but issuing our own requests to ADFS this can be get to work.

ADFS Preconfiguration required: https://www.youtube.com/watch?v=26OnuDSOZf4

I don't expect this to be merged/supported/whatever, just happened to experiment on this project.

@gitguardian
Copy link

gitguardian bot commented Jul 25, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic CLI Secret 445e562 src/index.ts View secret
- Generic CLI Secret 445e562 src/index.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant