steam build fixes

[LiquidityC]

• More steam build script fixes
• Improve beta release handling from release script

Summary by CodeRabbit

• New Features

  • Enhanced the installation process to automatically differentiate package components by build type, ensuring assets and data are correctly assigned to "Beta" (for Debug) or "Release" builds.

• Chores

  • Improved build configurations by enforcing static linking for executables and libraries, which enhances portability and reduces runtime dependencies.

[coderabbitai]

Walkthrough

The changes update the CMake configuration to dynamically set the package component based on the build type (using "Beta" for Debug builds and "Release" otherwise) and adjust installation targets accordingly. Additionally, the installation commands are refined by modifying asset and data directory installs. In the toolchain files for MinGW-w64 (both i686 and x86_64), new static linker flags are added to ensure executables and shared libraries are linked statically.

Changes

File(s)	Change Summary
CMakeLists.txt	Introduced a new variable PACKAGE_COMPONENT set to "Beta" for Debug builds and "Release" otherwise; updated CPACK_INSTALL_CMAKE_PROJECTS to use this variable; modified installation commands to handle separate installation targets and directories; removed NSIS uninstall setting.
build_deps/toolchains/mingw-w64-i686.cmake build_deps/toolchains/mingw-w64-x86_64.cmake	Added static linker flags (-static, -static-libgcc, -static-libstdc++) to both executable and shared library linker flag variables to enforce static linking.

Sequence Diagram(s)

sequenceDiagram
    participant Build as Build System
    participant CMake as CMake Configuration
    participant Installer as Install Process

    Build->>CMake: Initiate build
    CMake->>CMake: Check build type (Debug or other)
    alt Debug Build
        CMake->>CMake: Set PACKAGE_COMPONENT = "Beta"
    else Other Build
        CMake->>CMake: Set PACKAGE_COMPONENT = "Release"
    end
    CMake->>Installer: Configure installation targets using PACKAGE_COMPONENT
    Installer-->>CMake: Confirm installation configuration

Loading

Poem

I'm a rabbit, hopping with cheer,
Changes in CMake have now appeared.
Debug whispers "Beta", while Release stays grand,
Static linking flags lend a steady hand.
With code and carrots, I celebrate the day,
Leaping through builds in my own display!
🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 875c911 and 675f433.

📒 Files selected for processing (3)

• CMakeLists.txt (3 hunks)
• build_deps/toolchains/mingw-w64-i686.cmake (1 hunks)
• build_deps/toolchains/mingw-w64-x86_64.cmake (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: build (ubuntu-latest, Release, gcc)
• GitHub Check: build (ubuntu-latest, Debug, mingw-w64-gcc)
• GitHub Check: build (ubuntu-latest, Debug, clang)
• GitHub Check: build (macos-latest, Debug, clang)
• GitHub Check: build (ubuntu-latest, Release, mingw-w64-gcc)
• GitHub Check: build (ubuntu-latest, Debug, gcc)
• GitHub Check: build (ubuntu-latest, Release, clang)
• GitHub Check: Analyze (c-cpp)

🔇 Additional comments (8)

build_deps/toolchains/mingw-w64-i686.cmake (1)

10-12: Improved static linking for Windows builds

Adding these static linker flags ensures that the generated executables and shared libraries won't depend on dynamic versions of GCC's standard libraries. This is a good improvement for the Steam build as it eliminates potential runtime dependencies, making the distribution more reliable.

build_deps/toolchains/mingw-w64-x86_64.cmake (1)

10-12: Consistent static linking setup

This change matches the one made in the i686 toolchain file, ensuring static linking for both 32-bit and 64-bit builds. This consistency is important for maintaining the same behavior across different architectures.

CMakeLists.txt (6)

84-87: Good addition of build-type based package component

This dynamically sets the package component based on the build type, which helps distinguish between beta and release packages. This change supports the PR objective of enhancing beta release handling.

---

325-329: Improved installation target configuration

The installation target now properly includes both Release and Beta components, which allows the same target to be installed regardless of build type. This is cleaner than having separate installation commands.

---

335-338: Enhanced Beta build with unpacked assets

For non-Steam builds, this change ensures that Beta builds have access to raw asset and data directories instead of just the packed files. This is valuable for debugging and development purposes.

---

344-347: Consistent Beta component handling for Steam builds

Similar to the non-Steam build change, this ensures Steam builds also have access to unpacked assets in Beta mode, maintaining consistent behavior between Steam and non-Steam builds.

---

350-350: Dynamic package component selection

This change uses the dynamically determined PACKAGE_COMPONENT variable instead of the hardcoded "Release", ensuring that the correct components are included in the package based on the build type.

---

376-376: Simplified Windows packaging

Removing the NSIS generator option and using only ZIP for Windows simplifies the packaging configuration. This is appropriate since Steam handles the installation process for Steam builds.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.