-
-
Notifications
You must be signed in to change notification settings - Fork 7
Fix binary build destination #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes modify the Changes
Sequence Diagram(s)sequenceDiagram
participant C as CMake
participant I as Installer
Note over C: Evaluate STEAM condition
alt STEAM is defined
C->>I: Set runtime destination to "."
else STEAM is not defined
C->>I: Set runtime destination to "bin/"
end
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CMakeLists.txt (2)
325-334: Clarify Installation Destination for Non-Steam BuildsIn this block, the TARGET is installed with a runtime destination of
bin/and the asset files/directories are placed undershare/breakhack/. This clearly distinguishes the non-Steam build installation layout.It might be beneficial to add an inline comment briefly explaining why these particular destinations were chosen to enhance maintainability.
339-353: Correct Binary Installation Destination for Steam BuildsThe changes in the
else ()block correctly update the installation commands such that whenSTEAMis enabled, the target as well as the asset files and directories are installed to the current directory (.). This aligns with the PR objective of fixing the binary build destination for Steam builds.Consider adding a short comment indicating that this change ensures the Steam builds deploy binaries and related files in the working directory, which might help future maintainers understand the rationale.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CMakeLists.txt(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (11)
- GitHub Check: build (ubuntu-latest, Release, gcc)
- GitHub Check: build (macos-latest, Release, clang)
- GitHub Check: build (macos-latest, Debug, clang)
- GitHub Check: build (macos-latest, Debug, gcc)
- GitHub Check: build (macos-latest, Release, gcc)
- GitHub Check: build (ubuntu-latest, Debug, gcc)
- GitHub Check: build (ubuntu-latest, Release, mingw-w64-gcc)
- GitHub Check: build (ubuntu-latest, Release, clang)
- GitHub Check: build (ubuntu-latest, Debug, clang)
- GitHub Check: build (ubuntu-latest, Debug, mingw-w64-gcc)
- GitHub Check: Analyze (c-cpp)
Summary by CodeRabbit