Adds new animation for the Trip skill

[LiquidityC]

Summary by CodeRabbit

• Bug Fixes

  • Prevents unintended sword animation from triggering immediately when using the Trip skill.
  • Ensures the Trip skill consistently displays the correct animation and tooltip.

• Refactor

  • Centralized Trip skill initialization to include animation and tooltip setup, improving consistency and maintainability.

[coderabbitai]

Walkthrough

Trip skill initialization is refactored to encapsulate tooltip and animation setup within create_trip(Camera *). skill_create now calls create_trip(cam) for TRIP and no longer assigns the tooltip separately. The sword animation trigger in skill_trip was removed. Function signature of create_trip changed to accept a Camera pointer.

Changes

Cohort / File(s)	Summary
Trip skill initialization refactor src/skill.c	- Change create_trip signature: static Skill *create_trip(Camera *cam) (was static Skill *create_trip(void)). - skill_create(TRIP) updated to create_trip(cam) and removed separate tooltip assignment. - Moved Trip tooltip and animation construction into create_trip(cam). - Removed immediate sword animation run in skill_trip.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Game
  participant SkillFactory as skill_create(t, cam)
  participant Trip as create_trip(cam)
  participant Anim as Animation
  participant UI as Tooltip

  Game->>SkillFactory: request TRIP skill with cam
  SkillFactory->>Trip: create_trip(cam)
  Note right of Trip: Internalize setup for Trip
  Trip->>Anim: init texture, frames, loop, sprite, clip, pivot
  Trip->>UI: tooltip_create(trip_tooltip, cam)
  Trip-->>SkillFactory: Skill{ animation, tooltip, ... }
  SkillFactory-->>Game: return Skill

  Note over Game,Trip: Previous flow removed: no direct sword animation run in skill_trip

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Adds new backstab, erupt and vampiric blow animations #141 — Similar refactor: skill constructors accept Camera* and internalize tooltip/animation for other skills (vampiric_blow, backstab, erupt).
• Adds 3 new animations sprite sheets replaces sword swing. #133 — Applies the same pattern for other skills (e.g., flurry), aligning constructors and setup consolidation.

Poem

A hop and a flip, the Trip’s now neat,
Tooltips bloom where coders meet.
Animations bundled, tidy as hay,
No sword sprint on entry today.
I wiggle my whiskers, review complete—
Refactors make burrows so sweet! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title clearly and concisely describes the main change—adding a new animation for the Trip skill—which directly aligns with the code modifications in skill.c and the stated objectives.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch add_trip_animation

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5f94006 and 1fda825.

⛔ Files ignored due to path filters (1)

• assets/Extras/Trip.png is excluded by !**/*.png

📒 Files selected for processing (1)

• src/skill.c (3 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

src/skill.c (2)

src/tooltip.c (1)

• tooltip_create (122-129)

src/animation.c (3)

• animation_create (25-37)
• animation_load_texture (39-43)
• animation_set_frames (88-94)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: Mac (Clang)
• GitHub Check: Mac (GCC)
• GitHub Check: Ubuntu (Clang)
• GitHub Check: Ubuntu (GCC)
• GitHub Check: Ubuntu (mingw)
• GitHub Check: Windows (MSVC)
• GitHub Check: Analyze (c-cpp)

🔇 Additional comments (3)

src/skill.c (3)

659-659: Function signature updated to support encapsulation.

The signature change enables tooltip and animation creation within create_trip, consistent with similar skills like create_bash and create_flurry.

---

1158-1158: LGTM! Call site correctly updated.

The call to create_trip(cam) is now consistent with other skills that encapsulate their tooltip and animation setup (e.g., BASH, FLURRY).

---

674-692: Verify sprite sheet dimensions

Run the following to confirm the sheet is at least 256×32 pixels:

file assets/Extras/Trip.png

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}