Deployed contract addresses saved to file#200
Draft
0xJem wants to merge 5 commits intoOlympusDAO:mainfrom
Draft
Conversation
0xJem
force-pushed
the
dynamic-contract-addresses
branch
from
6b6341b to
918da04
Compare
|
We really need a sitdown on this topic. I would leave this open simply for this reason. I've been writing mini util with importable addresses in /test/utils on the allocator branch, and was thinking about directly writing. I don't see why we should rely on something like |
|
Yes, smart contracts are the root of all DAO projects. But integrating and and working could with them could be better, before any broader applications this should be checked one, five or 10-100 times by Security professionals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR throws out the previous approach of storing the deployment files (any time a contract was updated, it would invalidate the old file and require a manual update of the constants in olympus-frontend).
Instead, we now write the addresses into a JSON file in
addresses/addresses.json. This can be used by a local dev, but can also be passed to the frontend and ingested dynamically. Magic!