Add new allocator to migrate old LUSD allocator to and rescue funds#339
Open
0xLienid wants to merge 2 commits intoallocatorsfrom
Open
Add new allocator to migrate old LUSD allocator to and rescue funds#3390xLienid wants to merge 2 commits intoallocatorsfrom
0xLienid wants to merge 2 commits intoallocatorsfrom
Conversation
Oighty
reviewed
Apr 10, 2023
Oighty
left a comment
Oighty
left a comment
There was a problem hiding this comment.
Overall, looks fine. It's probably best to just do the rescue from the allocator vs. trying to migrate from this one to a new one.
| function sendETH(address to_) external { | ||
| _onlyGuardian(); | ||
|
|
||
| payable(to_).transfer(address(this).balance); |
There was a problem hiding this comment.
It's better to use a low-level call since if you send it to a smart contract wallet or a contract, it could get bricked in the future if the gas cost of op codes change. Transfer only forwards 2300 gas.
payable(to_).call{value: address(this).balance}("");
Contributor
Author
yep agreed. i just wanted to have the ability to migrate again in case something unexpected goes wrong with this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test CI check is failing because of some curve convex allocator test, nothing to do with this allocator