Skip to content

bldr/docker_utils.py: froce remove if kill fails at exit #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gergo-nyiro-oi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bldr/docker_utils.py: froce remove if kill fails at exit #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions bldr/docker_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,11 @@ def get_exit_code(self) -> int:
return self._client.api.inspect_container(self._container.id)['State'].get('ExitCode', 0)

def __exit__(self, exc_type, exc_val, exc_tb) -> None:
force_remove = False
try:
self._container.kill()
except APIError:
pass
except APIError as error:
force_remove = True
self._logger.error(f"Failed to kill container; {error=}")
finally:
self._container.remove()
self._container.remove(force=force_remove)
Loading