Skip to content

fix(web): align search icon style with other header icons#10016

Merged
limichange merged 3 commits intoOneKeyHQ:xfrom
ruiqiyang123:fix/web-header-search-icon-style
Feb 5, 2026
Merged

fix(web): align search icon style with other header icons#10016
limichange merged 3 commits intoOneKeyHQ:xfrom
ruiqiyang123:fix/web-header-search-icon-style

Conversation

@ruiqiyang123
Copy link
Contributor

@ruiqiyang123 ruiqiyang123 commented Feb 5, 2026

Summary

The search icon in the web dapp header was visually inconsistent with the other header icons (notification, menu, language, theme).

Root cause: UniversalSearchInput used a plain IconButton directly, while all other header icons use the shared HeaderIconButton wrapper which provides:

  • focusVisibleStyle={undefined} — removes the default focus outline, matching the other icons
  • tooltipProps={{ placement: 'bottom' }} — consistent tooltip positioning

Additionally, the icon was missing the size="small" prop, causing it to render at the default medium size ($6 icon / $1.5 padding) instead of small ($5 icon / $1 padding) like its siblings.

Changes

  • Replace IconButton with HeaderIconButton to match the shared header icon pattern
  • Pass size="small" to align icon and padding dimensions with other header icons
  • Replace hardcoded English title="Search everything" with intl.formatMessage using the existing ETranslations.global_search_everything key

Open with Devin
Open with Devin

@revan-zhang
Copy link
Contributor

revan-zhang commented Feb 5, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@limichange limichange enabled auto-merge (squash) February 5, 2026 06:44
@limichange limichange merged commit 08adc19 into OneKeyHQ:x Feb 5, 2026
6 checks passed
@ruiqiyang123 ruiqiyang123 deleted the fix/web-header-search-icon-style branch February 5, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants