fix(web): align search icon style with other header icons#10016
Merged
limichange merged 3 commits intoOneKeyHQ:xfrom Feb 5, 2026
Merged
fix(web): align search icon style with other header icons#10016limichange merged 3 commits intoOneKeyHQ:xfrom
limichange merged 3 commits intoOneKeyHQ:xfrom
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
weatherstar
approved these changes
Feb 5, 2026
huhuanming
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The search icon in the web dapp header was visually inconsistent with the other header icons (notification, menu, language, theme).
Root cause:
UniversalSearchInputused a plainIconButtondirectly, while all other header icons use the sharedHeaderIconButtonwrapper which provides:focusVisibleStyle={undefined}— removes the default focus outline, matching the other iconstooltipProps={{ placement: 'bottom' }}— consistent tooltip positioningAdditionally, the icon was missing the
size="small"prop, causing it to render at the defaultmediumsize ($6icon /$1.5padding) instead ofsmall($5icon /$1padding) like its siblings.Changes
IconButtonwithHeaderIconButtonto match the shared header icon patternsize="small"to align icon and padding dimensions with other header iconstitle="Search everything"withintl.formatMessageusing the existingETranslations.global_search_everythingkey