This repository was archived by the owner on Jan 29, 2023. It is now read-only.
The unique identifier of the unified wallet is id and the wallet name is name #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuaiLiWang
requested review from
huazhouwang and
taimanhui
and removed request for
taimanhui
huazhouwang
previously approved these changes
May 13, 2021
taimanhui
previously approved these changes
May 13, 2021
taimanhui
left a comment
taimanhui
left a comment
There was a problem hiding this comment.
_wallet_path的参数名可能也要同步改，不过影响不大。
这个应该会挂到下周二再合？
Author
是的 计划下周二合 |
shuaiLiWang
force-pushed
the
uniform_return_value_name
branch
from
4b9146f to
011ce7e
Compare
Author
|
这个pr主要是统一了返回值中的命名，原来的name改成id 原来的label改成name |
|
wallet manager 合并了，你需要 rebase 然后重新比对修改的地方 |
Author
好的 |
somebodyLi
approved these changes
May 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
统一账户的唯一标识为“id”，钱包的名称为“name”
Does this close any currently open issues?
If it fixes a bug or resolves a feature request, be sure to link to that issue.
…
Pull request type
Put an
xin the boxes that applyWhere has this been tested?
…
Any other comments?
…