Fix: QA version does not lock device.

[lihuanhuan]

Summary by CodeRabbit

• Chores
  • Enhanced production build stability by conditionally activating an internal safeguard that improves system reliability and security.

[coderabbitai]

Walkthrough

The pull request updates the gd32_protect function in legacy/firmware/fido2/ctap_trans.c. It replaces commented-out code with a conditional call to memory_protect() based on the PRODUCTION preprocessor directive. This change adjusts the control flow so that memory protection activates only on production builds.

Changes

File	Change Summary
legacy/firmware/fido2/ctap_trans.c	Removed commented-out code and added a conditional call to memory_protect() when PRODUCTION is defined.

Sequence Diagram(s)

sequenceDiagram
    participant Function as gd32_protect
    participant MP as memory_protect
    Function->>Function: Check PRODUCTION flag
    alt Production build
        Function->>MP: Call memory_protect()
    else Non-production build
        Function-->>Function: Skip memory protection
    end

Loading

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 809fcbd and 576f617.

📒 Files selected for processing (1)

• legacy/firmware/fido2/ctap_trans.c (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Defs check
• GitHub Check: Gen check
• GitHub Check: Style check

🔇 Additional comments (1)

legacy/firmware/fido2/ctap_trans.c (1)

522-527: Confirms memory protection logic is now correct.

This change makes the device locking behavior consistent with the PR objective. Now QA builds skip memory protection while production builds still enforce it.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.