fix(legacy): fix display issue

[somebodyLi]

Summary by CodeRabbit

• Style
  • Improved consistency in displaying transaction headers and titles during transaction signing.
• Bug Fixes
  • Ensured transaction titles are correctly formatted and localized with colons in the Solana transaction signing flow.

[coderabbitai]

Walkthrough

The changes update how transaction titles display in the user interface. They adjust title formatting and localization in Solana transaction signing, and add a header rendering call before showing key-value pairs during transaction signing. No public interfaces or logic flows were altered.

Changes

File(s)	Change Summary
legacy/firmware/layout2.c	Added a call to render the transaction header before displaying key-value pairs in signing UI.
legacy/firmware/solana.c	Changed title formatting for certain transaction steps: now appends a colon after localization. Also uses a new buffer for the localized title.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant Layout
    participant Localizer

    User->>UI: Initiate transaction signing
    UI->>Layout: Request to display transaction step (e.g., Sender, Recipient)
    Layout->>Localizer: Localize title string with colon (e.g., "From:")
    Localizer-->>Layout: Return localized title
    Layout->>UI: Display header and key-value pair with localized title

Loading

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between e35632d and 4239661.

📒 Files selected for processing (2)

• legacy/firmware/layout2.c (1 hunks)
• legacy/firmware/solana.c (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

legacy/firmware/layout2.c (1)

legacy/firmware/layout2.h (1)

• layoutHeader (219-219)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Gen check
• GitHub Check: Defs check
• GitHub Check: Style check

🔇 Additional comments (2)

legacy/firmware/layout2.c (1)

4139-4139: Good fix! Header now displays consistently across all transaction modes.

This ensures the transaction title header appears when showing key-value pairs, matching the behavior of other display modes in this function. Clean, targeted fix for the display issue.

legacy/firmware/solana.c (1)

159-159: Localization integration looks correct.

The gettext_from_en(desc) call properly handles the formatted title for translation.