fix(ui): resolve display issue

[lihuanhuan]

Summary by CodeRabbit

• Bug Fixes
  • Improved translation handling for the "Address:" label to ensure consistent localization.
  • Adjusted the search range for language items to improve accuracy in string localization.
  • Corrected dialog text alignment by centering strings horizontally on the display.

[coderabbitai]

Walkthrough

The changes update translation handling and display alignment in the firmware. They switch to using translation keys for string localization, adjust a loop boundary in the translation lookup, and modify a display function to center text horizontally. No public interfaces or exported declarations were changed.

Changes

File(s)	Change Summary
legacy/firmware/fsm_msg_nervos.h	Switched from direct string translation to using a translation key for the "Address:" label.
legacy/firmware/gettext.c	Changed loop boundary in gettext_from_en from I18N_LANGUAGE_ITEMS to I18N_ITEMS_COUNT.
legacy/firmware/layout2.c	Updated display function to center strings horizontally instead of aligning them to the left.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 698e94b and e820ac7.

📒 Files selected for processing (3)

• legacy/firmware/fsm_msg_nervos.h (1 hunks)
• legacy/firmware/gettext.c (1 hunks)
• legacy/firmware/layout2.c (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

legacy/firmware/layout2.c (3)

legacy/firmware/oled_text.c (1)

• oledDrawStringCenterAdapter (296-299)

legacy/firmware/oled_text.h (1)

• oledDrawStringCenterAdapter (23-23)

core/embed/rust/src/ui/geometry.rs (1)

• y (56-58)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Gen check
• GitHub Check: Style check
• GitHub Check: Defs check

🔇 Additional comments (3)

legacy/firmware/gettext.c (1)

27-27:

Details

✅ Verification successful

Verify the loop boundary change is safe.

The change from I18N_LANGUAGE_ITEMS to I18N_ITEMS_COUNT modifies search range. Ensure this matches the actual languages_en array size to prevent buffer overflows.

---

🏁 Script executed:

#!/bin/bash
# Verify the constant definitions and array sizes
echo "Searching for constant definitions..."
rg -A 2 -B 2 "I18N_ITEMS_COUNT|I18N_LANGUAGE_ITEMS" 

echo "Searching for languages_en array definition..."
rg -A 5 -B 2 "languages_en\s*\[.*\]|languages_en.*="

Length of output: 6522

---

🏁 Script executed:

#!/bin/bash
# Count entries in languages_en to verify it matches I18N_ITEMS_COUNT
echo "Counting entries in languages_en initializer..."
awk '
  /const char \*const languages_en\[\]/ { in_block=1; next }
  in_block && /\};/ { print "Total entries:", count; exit }
  in_block && /"/        { count++ }
' legacy/firmware/i18n/locales/en.inc
echo "Defined I18N_ITEMS_COUNT: $(grep -Po '(?<=#define I18N_ITEMS_COUNT )\d+' legacy/firmware/i18n/i18n.h)"

Length of output: 472

---

I18N_ITEMS_COUNT matches languages_en size; change is safe

The languages_en array has 383 entries and I18N_ITEMS_COUNT is defined as 383. The loop boundary now exactly matches the array size, so there’s no overflow risk.

legacy/firmware/fsm_msg_nervos.h (1)

44-44:

Details

✅ Verification successful

Good move to standardized translation keys.

Using _(I__ADDRESS_COLON) instead of __("Address:") improves consistency. Verify the constant is defined correctly.

---

🏁 Script executed:

#!/bin/bash
# Check if I__ADDRESS_COLON is defined and what it maps to
echo "Searching for I__ADDRESS_COLON definition..."
rg -A 2 -B 2 "I__ADDRESS_COLON"

echo "Searching for translation constants pattern..."
rg -A 1 -B 1 "I__[A-Z_]+\s*="

Length of output: 1972

---

I18n Key Confirmed

I located I__ADDRESS_COLON in legacy/firmware/i18n/keys.h (value 190, comment “// Address:”). It matches the intended translation. Change approved.

legacy/firmware/layout2.c (1)

2709-2709: Center dialog description text
Using OLED_WIDTH/2 ensures desc is drawn centered instead of at x=0.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.