Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
guowei0105
previously approved these changes
Feb 6, 2026
There was a problem hiding this comment.
Pull request overview
This PR implements several fixes and improvements for the OneKey hardware wallet firmware, focusing on Stellar blockchain integration, multi-chain support, and bug fixes. The changes upgrade the firmware from version 3.17.2 to 3.18.0 and include substantial refactoring of the Stellar transaction signing UI.
Changes:
- Fixed BTC multi-sig signing by properly setting the serialized field flag
- Renamed EVM chain "Optimistic" to "Optimism" for accuracy
- Added Cardano testnet message signing support with protocol magic parameter
- Increased Ethereum access list storage keys capacity from 8 to 16
- Completely refactored Stellar transaction signing UI to use a new paginated dialog system
- Added internationalization strings for Stellar transactions across all supported languages
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| legacy/firmware/version.h | Version bump to 3.18.0 |
| legacy/firmware/signing.c | Added missing has_serialized flag for BTC multi-sig signing |
| legacy/firmware/ethereum_onekey.h | Renamed "Optimistic" chain to "Optimism" |
| legacy/firmware/ada.c | Added protocol_magic support for testnet message signing |
| legacy/firmware/fsm_msg_ada.h | Updated network validation to require protocol_magic for non-mainnet |
| legacy/firmware/protob/messages-ethereum-onekey.options | Increased storage_keys max_count from 8 to 16 |
| legacy/firmware/stellar.c | Major refactoring of transaction UI with new dialog system and error handling |
| legacy/firmware/stellar.h | Updated function signatures for new dialog system |
| legacy/firmware/fsm_msg_stellar.h | Simplified operation confirmation flow with GO_AHEAD macro |
| legacy/firmware/i18n/* | Added 9 new translation strings for Stellar across all locales |
| legacy/firmware/i18n/keys.h | Added i18n key definitions (with one duplicate issue) |
| legacy/firmware/i18n/i18n.h | Updated item count to 455 |
| common/protob/messages-management.proto | Reserved fields 519, 522, 523 for pro version |
| common/protob/messages-cardano.proto | Added optional protocol_magic field for testnet support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lihuanhuan
previously approved these changes
Feb 6, 2026
somebodyLi
dismissed stale reviews from lihuanhuan and guowei0105
via
a608735
1. BTC multi-sig signing issue 2. rename EVM chain `Optimistic` to `Optimism` 3. support ADA testnet message signing 4. increase the storage keys size which in Ethereum transaction signing
lihuanhuan
approved these changes
Feb 6, 2026
guowei0105
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OptimistictoOptimism