Skip to content

fix(core/i18n): update i18n#290

Merged
somebodyLi merged 1 commit intomainfrom
fix/i18n
Apr 15, 2025
Merged

fix(core/i18n): update i18n#290
somebodyLi merged 1 commit intomainfrom
fix/i18n

Conversation

@somebodyLi
Copy link
Copy Markdown
Contributor

@somebodyLi somebodyLi commented Apr 15, 2025

Summary by CodeRabbit

  • Style
    • Updated all supported languages to use "OneKey App" instead of "OneKey Wallet" for product references.
    • Improved phrasing and punctuation in some network support descriptions for Chinese localizations.
  • Chores
    • Adjusted internal internationalization key assignments to maintain consistency after adding the new "OneKey App" label.

@somebodyLi somebodyLi requested a review from a team as a code owner April 15, 2025 03:56
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 15, 2025

Walkthrough

The updates change the name "OneKey Wallet" to "OneKey App" across key definitions and all locale translation files. A new key for "TITLE__ONEKEY_APP" is added, and several internationalization keys are renumbered to maintain sequence. Locale files in multiple languages are updated to reflect the new product name and, in some cases, minor textual adjustments for clarity or consistency. No logic or control flow is changed.

Changes

Files Change Summary
core/src/trezor/lvglui/i18n/keys.py Added TITLE__ONEKEY_APP key, renamed comment, renumbered several keys starting from 870.
core/src/trezor/lvglui/i18n/locales/de.py
core/src/trezor/lvglui/i18n/locales/en.py
core/src/trezor/lvglui/i18n/locales/es.py
core/src/trezor/lvglui/i18n/locales/fr.py
core/src/trezor/lvglui/i18n/locales/it.py
core/src/trezor/lvglui/i18n/locales/ja.py
core/src/trezor/lvglui/i18n/locales/ko.py
core/src/trezor/lvglui/i18n/locales/pt_br.py
core/src/trezor/lvglui/i18n/locales/ru.py
core/src/trezor/lvglui/i18n/locales/zh_cn.py
core/src/trezor/lvglui/i18n/locales/zh_hk.py
Updated translations to replace "OneKey Wallet" with "OneKey App" and removed/adjusted related strings.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ceac15b and 1281039.

📒 Files selected for processing (12)
  • core/src/trezor/lvglui/i18n/keys.py (2 hunks)
  • core/src/trezor/lvglui/i18n/locales/de.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/en.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/es.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/fr.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/it.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/ja.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/ko.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/pt_br.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/ru.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/zh_cn.py (2 hunks)
  • core/src/trezor/lvglui/i18n/locales/zh_hk.py (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Style check
  • GitHub Check: Defs check
  • GitHub Check: Gen check
🔇 Additional comments (10)
core/src/trezor/lvglui/i18n/locales/pt_br.py (1)

723-723: Spelling and grammar look good.

core/src/trezor/lvglui/i18n/locales/de.py (1)

723-723: No issues found.

core/src/trezor/lvglui/i18n/locales/fr.py (1)

723-723: Looks good.

core/src/trezor/lvglui/i18n/locales/en.py (1)

723-723: No problems here.

core/src/trezor/lvglui/i18n/locales/zh_cn.py (2)

723-723: All clear.


805-805: No issues.

core/src/trezor/lvglui/i18n/locales/zh_hk.py (2)

723-723: Product name updated.

Name changed from "OneKey Wallet" to "OneKey App" for consistency.


805-805: Network support string updated with new product name.

Translation updated to use "OneKey App" instead of previous product name.

core/src/trezor/lvglui/i18n/keys.py (2)

1578-1580: New app title key added.

New constant TITLE__ONEKEY_APP added with same value as ITEM__ONEKEY_WALLET.


1908-1951: Keys renumbered for sequential ordering.

Constants from GLOBAL_CANDIDATE onward shifted down by one to maintain proper sequence.

@somebodyLi somebodyLi merged commit 1430826 into main Apr 15, 2025
7 checks passed
@somebodyLi somebodyLi deleted the fix/i18n branch April 15, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants