Use UART receiver timeout for data reception.

[lihuanhuan]

Summary by CodeRabbit

• New Features

  • Improved UART reception handling by introducing a receiver timeout mechanism based on baud rate and bit timing for more precise detection of received data.

• Bug Fixes

  • Replaced the previous fixed timeout and IDLE line detection with a more accurate receiver timeout, enhancing reliability in data reception.

[coderabbitai]

Walkthrough

The code now uses a receiver timeout to detect the end of UART data reception instead of relying on the IDLE line. The timeout is set based on the baud rate and a defined duration in milliseconds. The interrupt handler now checks for the receiver timeout flag and processes received data accordingly. All changes are internal and do not affect public interfaces.

Changes

File(s)	Change Summary
core/embed/trezorhal/usart.c	Switched from IDLE line detection to receiver timeout for UART reception. Calculated timeout based on baud rate. Updated interrupt handling and DMA logic.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1b9210c and 10ea14f.

📒 Files selected for processing (1)

• core/embed/trezorhal/usart.c (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Gen check
• GitHub Check: Style check
• GitHub Check: Defs check

🔇 Additional comments (4)

core/embed/trezorhal/usart.c (4)

12-15: Added proper baud rate and timing constants.

The constants define baud rate and calculates bit timing. The timeout is fixed.

---

66-66: Uses macro instead of hardcoded value.

The change improves consistency.

---

128-131: Replaced IDLE with receiver timeout.

Uses receiver timeout instead of IDLE line detection. Calculates timeout in bit times.

---

285-286: Checks for receiver timeout flag.

Checks RTOF flag instead of IDLE, correctly clears it.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.