Skip to content

fix: screen freeze issue && optimize sram usage#300

Merged
Lu1zz merged 1 commit intoOneKeyHQ:mainfrom
Lu1zz:main
Apr 21, 2025
Merged

fix: screen freeze issue && optimize sram usage#300
Lu1zz merged 1 commit intoOneKeyHQ:mainfrom
Lu1zz:main

Conversation

@Lu1zz
Copy link
Copy Markdown
Contributor

@Lu1zz Lu1zz commented Apr 21, 2025

Summary by CodeRabbit

  • Refactor
    • Reduced the font cache size, which may affect how many fonts can be cached simultaneously.
    • Improved consistency in address generation by updating default context handling.
    • Updated address display logic to use a different context for certain operations.

Signed-off-by: Lu1zz <yu.lu@onekey.so>
@Lu1zz Lu1zz requested a review from a team as a code owner April 21, 2025 10:40
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 21, 2025

Walkthrough

The font cache size constant in the LVGL header was reduced from 64 to 32. In the address manager, the default context for generating addresses was changed to use a dummy context from the wire module. In the homescreen script, the context passed to the address retrieval function was switched from a dummy context to a QR context.

Changes

Files/Paths Change Summary
core/embed/lvgl/lv_font_ex.h Reduced FONT_CACHE_NUM from 64 to 32.
core/src/trezor/lvglui/scrs/address.py Changed default ctx in generate_address to wire.DUMMY_CONTEXT.
core/src/trezor/lvglui/scrs/homescreen.py Switched context in btc_get_address from DummyContext to QRContext.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f484f52 and 5658ee5.

📒 Files selected for processing (3)
  • core/embed/lvgl/lv_font_ex.h (1 hunks)
  • core/src/trezor/lvglui/scrs/address.py (1 hunks)
  • core/src/trezor/lvglui/scrs/homescreen.py (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
core/src/trezor/lvglui/scrs/homescreen.py (1)
core/src/trezor/wire/__init__.py (1)
  • QRContext (140-219)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Gen check
  • GitHub Check: Defs check
  • GitHub Check: Style check
🔇 Additional comments (3)
core/embed/lvgl/lv_font_ex.h (1)

32-32: Reduced font cache size from 64 to 32.

The change aligns with PR objectives to fix screen freeze and optimize SRAM usage.

core/src/trezor/lvglui/scrs/homescreen.py (1)

710-710: Switch to QRContext looks good.

The change from DummyContext to QRContext aligns with the PR's screen freeze fix objective.

core/src/trezor/lvglui/scrs/address.py (1)

681-681: Good SRAM optimization.

Changed default context from None to wire.DUMMY_CONTEXT to reuse existing object. Saves memory.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Lu1zz Lu1zz requested review from guowei0105 and somebodyLi April 21, 2025 10:42
@Lu1zz Lu1zz merged commit e9f24c4 into OneKeyHQ:main Apr 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants