Skip to content

fix bootloader validation && adjust touchscreen sensitivity#301

Merged
lihuanhuan merged 2 commits intoOneKeyHQ:mainfrom
lihuanhuan:pro_main
Apr 23, 2025
Merged

fix bootloader validation && adjust touchscreen sensitivity#301
lihuanhuan merged 2 commits intoOneKeyHQ:mainfrom
lihuanhuan:pro_main

Conversation

@lihuanhuan
Copy link
Copy Markdown
Contributor

@lihuanhuan lihuanhuan commented Apr 22, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Improved fallback handling for firmware verification on older hardware versions, ensuring proper operation when certain firmware files are missing.
    • Updated touchscreen configuration defaults, including reduced shake sensitivity and touch detection level, for improved performance and reliability.

@lihuanhuan lihuanhuan requested a review from a team as a code owner April 22, 2025 15:11
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 22, 2025

Walkthrough

The updates change configuration values and version checks in the GT911 touch controller code. In the firmware image verification code, the logic now checks if a secondary firmware file exists before loading or copying data, and adds a fallback for older hardware if the file is missing.

Changes

Files Change Summary
core/embed/trezorhal/gt911.c Updated config version check from 0x4F to 0x50. Changed config values for shake_count and screen_touch_level.
core/embed/trezorhal/image.c Added check for P2 firmware file existence. Added fallback for older hardware if file is missing.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between d69e7a4 and 14a37bb.

📒 Files selected for processing (2)
  • core/embed/trezorhal/gt911.c (1 hunks)
  • core/embed/trezorhal/image.c (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • core/embed/trezorhal/gt911.c
  • core/embed/trezorhal/image.c
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Defs check
  • GitHub Check: Gen check
  • GitHub Check: Style check

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9f24c4 and d69e7a4.

📒 Files selected for processing (2)
  • core/embed/trezorhal/gt911.c (1 hunks)
  • core/embed/trezorhal/image.c (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Style check
  • GitHub Check: Gen check
  • GitHub Check: Defs check
🔇 Additional comments (4)
core/embed/trezorhal/gt911.c (4)

143-143: Changed version check

Version check changed from 0x4F to 0x50.


149-149: Updated config version

Config version updated from 0x4F to 0x50.


151-151: Reduced shake count

Shake count halved from 0x22 to 0x11.


153-153: Lowered touch level

Screen touch level reduced from 0xA0 to 0x60.

@lihuanhuan lihuanhuan merged commit 73c30e6 into OneKeyHQ:main Apr 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants