-
Notifications
You must be signed in to change notification settings - Fork 16
update attach to pin i18n text #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe update revises the instructional message for the "Attach to PIN" feature across multiple language files. The new text clarifies that users should use the latest version of the OneKey App, replacing previous generic update prompts. Only translation strings and related comments were changed. Changes
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
core/src/trezor/lvglui/i18n/keys.py (1)
2231-2232: Avoid repeating “use”.-# Use the latest version of the OneKey App to use “Attach to PIN”. +# Use the latest OneKey App to enable “Attach to PIN”.core/src/trezor/lvglui/i18n/locales/en.py (1)
1017-1018: Avoid repeating “use”.-"Use the latest version of the OneKey App to use “Attach to PIN”.", +"Use the latest OneKey App to enable “Attach to PIN”.",core/src/trezor/lvglui/i18n/locales/zh_hk.py (1)
1017-1017: Inconsistent casing and quotes
Use the same “App” casing and quote style as elsewhere.core/src/trezor/lvglui/i18n/locales/pt_br.py (1)
1017-1017: Redundant wording
Repetition of “Use” / “usar”.core/src/trezor/lvglui/i18n/locales/de.py (1)
1017-1017: Doppelte Verben, klingt holprig.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (12)
core/src/trezor/lvglui/i18n/keys.py(1 hunks)core/src/trezor/lvglui/i18n/locales/de.py(1 hunks)core/src/trezor/lvglui/i18n/locales/en.py(1 hunks)core/src/trezor/lvglui/i18n/locales/es.py(1 hunks)core/src/trezor/lvglui/i18n/locales/fr.py(1 hunks)core/src/trezor/lvglui/i18n/locales/it.py(1 hunks)core/src/trezor/lvglui/i18n/locales/ja.py(1 hunks)core/src/trezor/lvglui/i18n/locales/ko.py(1 hunks)core/src/trezor/lvglui/i18n/locales/pt_br.py(1 hunks)core/src/trezor/lvglui/i18n/locales/ru.py(1 hunks)core/src/trezor/lvglui/i18n/locales/zh_cn.py(1 hunks)core/src/trezor/lvglui/i18n/locales/zh_hk.py(1 hunks)
👮 Files not reviewed due to content moderation or server errors (2)
- core/src/trezor/lvglui/i18n/locales/ja.py
- core/src/trezor/lvglui/i18n/locales/ru.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Gen check
- GitHub Check: Defs check
- GitHub Check: Style check
🔇 Additional comments (5)
core/src/trezor/lvglui/i18n/locales/fr.py (1)
1017-1017: Translation update looks correct.French text is grammatically sound and uses proper French quotation marks.
core/src/trezor/lvglui/i18n/locales/ko.py (1)
1017-1017: Korean translation update is correct.Grammar and terminology are appropriate for Korean users.
core/src/trezor/lvglui/i18n/locales/zh_cn.py (1)
1017-1017: Chinese translation update is correct.Grammar and terminology are appropriate for Chinese users.
core/src/trezor/lvglui/i18n/locales/es.py (1)
1017-1017: Artículo incorrecto
[ suggest_nitpick ]core/src/trezor/lvglui/i18n/locales/it.py (1)
1017-1017: Preposizione errata
[ suggest_nitpick ]
attach to pin i18n update
Summary by CodeRabbit