fix: remove reset pin verification

[guowei0105]

Summary by CodeRabbit

• Bug Fixes

  • Improved the alignment and positioning of subtitles and keyboard input areas on the PIN entry screen, ensuring a more consistent and visually appealing layout across different scenarios.

• Refactor

  • Simplified the logic for subtitle alignment and keyboard positioning on the PIN entry screen for better maintainability.

• Chores

  • Removed the PIN verification step from the device wipe process.

[coderabbitai]

Walkthrough

The update removes PIN verification from the device wipe process. It also refines how subtitle alignment and keyboard positioning are handled in the PIN input screen. No changes affect public interfaces or exported function signatures.

Changes

Files/Paths	Change Summary
core/src/apps/management/wipe_device.py	Removed PIN verification step from device wipe flow.
core/src/trezor/lvglui/scrs/pinscreen.py	Refined subtitle alignment and keyboard positioning logic in PIN input screen.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0045c61 and ab4addc.

📒 Files selected for processing (2)

• core/src/apps/management/wipe_device.py (0 hunks)
• core/src/trezor/lvglui/scrs/pinscreen.py (3 hunks)

💤 Files with no reviewable changes (1)

• core/src/apps/management/wipe_device.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Gen check
• GitHub Check: Defs check
• GitHub Check: Style check

🔇 Additional comments (4)

core/src/trezor/lvglui/scrs/pinscreen.py (4)

221-225: Check offset logic consistency.

Standard wallet uses smaller offset for taller titles, but non-standard wallet uses larger offset for taller titles. This seems backwards.

---

248-250: Same offset logic issue here.

Uses smaller offset (8) for taller titles, larger offset (16) for shorter titles. Verify this is intended behavior.

---

262-268: LGTM on keyboard alignment logic.

---

328-329: Good refactoring.

Extracting the text retrieval improves readability and avoids multiple method calls.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[revan-zhang]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)