fix(core): update i18n items and slip-39 group threshold reached warn… #364
Conversation
WalkthroughThis update changes user-facing messages for PIN attachment and group threshold prompts across multiple languages. It replaces references to needing the latest app version with statements about unsupported features. A new message about group threshold limits is added. UI prompt logic is also adjusted for EIP-1559 transaction confirmations. Changes
Estimated code review effort2 (45 minutes) 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (14)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (12)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
core/src/trezor/lvglui/i18n/keys.py (1)
2239-2240: GrammarMissing article “a”.
core/src/trezor/lvglui/i18n/locales/it.py (1)
1017-1017: Terminology mismatchEarlier strings use “Allega al PIN”. Keep wording consistent.
core/src/trezor/lvglui/i18n/locales/es.py (1)
1021-1021: Inconsistent termMost lines use “acción” (or “Share”). Swap “participación” for consistency.
core/src/trezor/lvglui/i18n/locales/fr.py (1)
1016-1018: Terminology mismatch“broche” vs “code PIN”. Use one term.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (14)
core/src/apps/ethereum/onekey/sign_tx_eip1559.py(1 hunks)core/src/apps/management/recovery_device/layout.py(1 hunks)core/src/trezor/lvglui/i18n/keys.py(1 hunks)core/src/trezor/lvglui/i18n/locales/de.py(1 hunks)core/src/trezor/lvglui/i18n/locales/en.py(1 hunks)core/src/trezor/lvglui/i18n/locales/es.py(1 hunks)core/src/trezor/lvglui/i18n/locales/fr.py(1 hunks)core/src/trezor/lvglui/i18n/locales/it.py(1 hunks)core/src/trezor/lvglui/i18n/locales/ja.py(1 hunks)core/src/trezor/lvglui/i18n/locales/ko.py(1 hunks)core/src/trezor/lvglui/i18n/locales/pt_br.py(1 hunks)core/src/trezor/lvglui/i18n/locales/ru.py(1 hunks)core/src/trezor/lvglui/i18n/locales/zh_cn.py(1 hunks)core/src/trezor/lvglui/i18n/locales/zh_hk.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Style check
- GitHub Check: Defs check
- GitHub Check: Gen check
🔇 Additional comments (15)
core/src/trezor/lvglui/i18n/locales/en.py (1)
1017-1017: Changes look good.Both message updates are clear and grammatically correct. The PIN attachment message is more direct, and the group threshold message is clear.
Also applies to: 1021-1021
core/src/trezor/lvglui/i18n/locales/ja.py (1)
1017-1017: Translation updates consistent.Changes follow the same pattern as English version. String formatting looks correct.
Also applies to: 1021-1021
core/src/trezor/lvglui/i18n/locales/ru.py (1)
1017-1017: Translation updates consistent.Changes follow the same pattern as other language versions. String formatting looks correct.
Also applies to: 1021-1021
core/src/apps/management/recovery_device/layout.py (1)
205-208: Good internationalization improvement.Replaced hardcoded string with proper i18n key. Added explicit UI parameters for consistency.
core/src/trezor/lvglui/i18n/locales/ko.py (2)
1017-1017: Translation looks correct.Clear Korean phrasing for unsupported feature message.
1021-1021: Good Korean translation.Proper terminology and grammar for group threshold message.
core/src/apps/ethereum/onekey/sign_tx_eip1559.py (1)
132-136: Smart UX improvement.Better title for zero-value contract interactions vs actual transfers.
core/src/trezor/lvglui/i18n/locales/de.py (2)
1017-1017: Correct German translation.Proper grammar and quotation marks used.
1021-1021: Well-formed German text.Proper case usage and sentence structure.
core/src/trezor/lvglui/i18n/locales/pt_br.py (2)
1017-1017: Translation updated correctly.Message changed from app update instruction to version limitation notice.
1021-1021: New group threshold message added.Portuguese translation is accurate and clear.
core/src/trezor/lvglui/i18n/locales/zh_cn.py (2)
1017-1017: Chinese translation updated correctly.Message properly conveys version limitation instead of app update requirement.
1021-1021: New threshold message translated well.Chinese text is clear and matches the intended functionality.
core/src/trezor/lvglui/i18n/locales/zh_hk.py (2)
1017-1017: Traditional Chinese translation correct.Version limitation message properly conveyed.
1021-1021: Group threshold message added properly.Traditional Chinese text is accurate and well-formatted.
…ing description
Summary by CodeRabbit
New Features
Improvements
Localization