fix attach to pin issue #367

guowei0105 · 2025-07-23T04:01:02Z

Summary by CodeRabbit

New Features
- Improved session management to automatically start a new session after unlocking the device via PIN, passphrase, fingerprint, BLE pairing, or user verification.
Bug Fixes
- Removed an unused and commented-out attribute check related to passphrase state handling.

revan-zhang · 2025-07-23T04:01:14Z

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

coderabbitai · 2025-07-23T04:01:15Z

Walkthrough

The changes add calls to storage.cache.start_session() after device unlock events in multiple modules, covering PIN, passphrase, fingerprint, BLE pairing, and WebAuthn unlocks. Some PIN type constants were updated for clarity. A redundant PIN verification block and a commented-out check were removed. No public API signatures were changed.

Changes

Files/Groups	Change Summary
core/src/apps/base.py	Added `storage.cache.start_session()` after unlocks; removed commented check; replaced literal pin type with constant.
core/src/apps/homescreen/lockscreen.py	Added `storage.cache.start_session()` after device unlock in coroutine.
core/src/apps/webauthn/fido2.py	Added `storage.cache.start_session()` after unlock in async functions.
core/src/trezor/uart.py	Added `storage.cache.start_session()` after unlock in fingerprint and BLE pairing handlers.
core/src/trezor/lvglui/scrs/lockscreen.py	Added `storage.cache.start_session()` after spawning unlock_device in UI event handlers.
core/src/boot.py	Added `storage.cache.start_session()` after PIN verification.
core/src/apps/management/change_pin.py	Updated pin type constant in PIN verification call.
core/src/apps/management/change_wipe_code.py	Added explicit pin type argument in PIN verification call.
core/src/trezor/ui/layouts/lvgl/attach_to_pin.py	Removed redundant PIN verification block after saving passphrase pin.

Estimated code review effort

3 (~40 minutes)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 684e295 and e305079.

📒 Files selected for processing (1)

core/src/apps/management/change_wipe_code.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

core/src/apps/management/change_wipe_code.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Gen check
GitHub Check: Style check
GitHub Check: Defs check

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 1be7e4d and 64830ea.

📒 Files selected for processing (3)

core/src/apps/base.py (3 hunks)
core/src/boot.py (2 hunks)
core/src/trezor/lvglui/scrs/lockscreen.py (2 hunks)

🪛 Ruff (0.12.2)

core/src/boot.py

21-21: SyntaxError: Expected an identifier

🚧 Files skipped from review as they are similar to previous changes (1)

core/src/apps/base.py

🧰 Additional context used

🪛 Ruff (0.12.2)

core/src/boot.py

21-21: SyntaxError: Expected an identifier

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Gen check
GitHub Check: Defs check
GitHub Check: Style check

🔇 Additional comments (3)

core/src/trezor/lvglui/scrs/lockscreen.py (2)

193-196: LGTM - session start after unlock workflow.

Correctly adds session initialization after spawning unlock workflow.

208-211: LGTM - consistent session handling.

Same pattern applied to slide-up gesture handler.

core/src/boot.py (1)

39-39: LGTM - proper session start placement.

Correctly positioned after PIN verification and before storage unlock.

core/src/boot.py

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

core/src/apps/management/change_wipe_code.py (1)
34-34: Missing space after comma.

salt,PinType.USER_CHECK should be salt, PinType.USER_CHECK.
-        if config.has_pin() and not config.check_pin(pin, salt,PinType.USER_CHECK)[0]:
+        if config.has_pin() and not config.check_pin(pin, salt, PinType.USER_CHECK)[0]:
core/src/apps/management/change_pin.py (1)

113-133: Remove dead code.

These commented blocks should be deleted.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 1824066 and 684e295.

📒 Files selected for processing (3)

core/src/apps/management/change_pin.py (1 hunks)
core/src/apps/management/change_wipe_code.py (1 hunks)
core/src/trezor/ui/layouts/lvgl/attach_to_pin.py (0 hunks)

💤 Files with no reviewable changes (1)

core/src/trezor/ui/layouts/lvgl/attach_to_pin.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Defs check
GitHub Check: Gen check
GitHub Check: Style check

🔇 Additional comments (1)

core/src/apps/management/change_pin.py (1)

53-55: Good clarification of PIN type usage.

The change from PinType.PASSPHRASE_PIN to PinType.PASSPHRASE_PIN_CHECK improves semantic clarity.

guowei0105 added 2 commits July 23, 2025 11:56

fix attach to pin issue

e8847f1

format code

1be7e4d

guowei0105 requested a review from a team as a code owner July 23, 2025 04:01

guowei0105 requested review from 424778940z, lihuanhuan and somebodyLi July 23, 2025 04:01

lihuanhuan previously approved these changes Jul 23, 2025

View reviewed changes

add bootscreen new session

64830ea

guowei0105 dismissed lihuanhuan’s stale review via 64830ea July 23, 2025 04:33

coderabbitai bot reviewed Jul 23, 2025

View reviewed changes

core/src/boot.py Outdated Show resolved Hide resolved

restore bootscreen code

1824066

lihuanhuan previously approved these changes Jul 23, 2025

View reviewed changes

Lu1zz previously approved these changes Jul 23, 2025

View reviewed changes

adjust change-code check pin

684e295

guowei0105 dismissed stale reviews from Lu1zz and lihuanhuan via 684e295 July 23, 2025 05:24

coderabbitai bot reviewed Jul 23, 2025

View reviewed changes

format code

e305079

lihuanhuan approved these changes Jul 23, 2025

View reviewed changes

Lu1zz approved these changes Jul 23, 2025

View reviewed changes

guowei0105 merged commit 01ea1e3 into OneKeyHQ:main Jul 23, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix attach to pin issue #367

fix attach to pin issue #367

Uh oh!

guowei0105 commented Jul 23, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

revan-zhang commented Jul 23, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 23, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix attach to pin issue #367

fix attach to pin issue #367

Uh oh!

Conversation

guowei0105 commented Jul 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

revan-zhang commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Snyk checks have passed. No issues have been found so far.

Uh oh!

coderabbitai bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

guowei0105 commented Jul 23, 2025 •

edited by coderabbitai bot

Loading

revan-zhang commented Jul 23, 2025 •

edited

Loading

coderabbitai bot commented Jul 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)