fix(core): fix the safe transaction detection issue when the call dat…

[somebodyLi]

…a size large than 1024

Summary by CodeRabbit

• New Features

  • Improved handling of leftover transaction data during Ethereum transaction signing, enhancing robustness for complex transactions.

• Bug Fixes

  • Enhanced parsing and validation of nested call data and signatures in safe transactions.
  • Improved UI responsiveness by resuming the display when scrolling mnemonic words during device reset.

• Chores

  • Cleaned up import statements for better code organization.

[coderabbitai]

Walkthrough

A global buffer for leftover transaction data is introduced in Ethereum signing code. Data chunk handling is updated to use this buffer when available. Signature parsing and validation are improved. UI code now handles scroll events to resume the LCD and cleans up imports.

Changes

Files/Paths	Change Summary
core/src/apps/ethereum/onekey/sign_tx.py	Adds global buffer for leftover data, new helper functions, updates data chunk and signature logic.
core/src/apps/ethereum/onekey/sign_tx_eip1559.py	Updates data chunk handling to use buffer, resets buffer after checks.
core/src/trezor/lvglui/scrs/reset_device.py	Adds event bubbling, handles scroll events to resume LCD, moves imports.

Estimated code review effort

3 (~40 minutes)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[revan-zhang]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

core/src/apps/ethereum/onekey/sign_tx.py (1)

370-370: Fix Yoda condition.

-        and 437 <= msg.data_length
+        and msg.data_length >= 437

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 01ea1e3 and 4e63320.

📒 Files selected for processing (3)

• core/src/apps/ethereum/onekey/sign_tx.py (7 hunks)
• core/src/apps/ethereum/onekey/sign_tx_eip1559.py (3 hunks)
• core/src/trezor/lvglui/scrs/reset_device.py (4 hunks)

🪛 Ruff (0.12.2)

core/src/apps/ethereum/onekey/sign_tx.py

370-370: Yoda condition detected

Rewrite as msg.data_length >= 437

(SIM300)

🧰 Additional context used

🪛 Ruff (0.12.2)

core/src/apps/ethereum/onekey/sign_tx.py

370-370: Yoda condition detected

Rewrite as msg.data_length >= 437

(SIM300)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Style check
• GitHub Check: Gen check
• GitHub Check: Defs check

🔇 Additional comments (4)

core/src/trezor/lvglui/scrs/reset_device.py (1)

3-3: LGTM!

Import moved to top-level. Event handling improved.

Also applies to: 87-87, 103-103, 107-107, 145-146, 488-488

core/src/apps/ethereum/onekey/sign_tx_eip1559.py (2)

33-33: LGTM!

Good optimization for handling leftover transaction data chunks.

Also applies to: 39-39, 268-276

---

333-333: LGTM!

Proper cleanup of leftover data state.

core/src/apps/ethereum/onekey/sign_tx.py (1)

44-44: No thread safety issue detected.

Likely an incorrect or invalid review comment.