fix(keyboard): fix the vibration issue with the DEL button

[somebodyLi]

Summary by CodeRabbit

• New Features

  • Improved haptic feedback on all keyboard inputs by preventing repeated vibrations during continuous key presses or holds.
  • Haptic feedback is now reset and can be triggered again after a long press, enhancing the user experience during extended input.

• Bug Fixes

  • Resolved issues with redundant vibrations when holding down keys, ensuring more precise and consistent feedback.

[coderabbitai]

Walkthrough

The code adds a self.vibrated flag to four keyboard classes. It updates event callbacks to handle the LONG_PRESSED event and control motor vibration. The logic now avoids repeated vibrations during long key presses by tracking vibration state.

Changes

Cohort / File(s)	Change Summary
Keyboard vibration state handling core/src/trezor/lvglui/scrs/components/keyboard.py	Added self.vibrated flag and updated event callbacks in four keyboard classes to manage vibration during press and hold events.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 6d8c8cd and 4db1473.

📒 Files selected for processing (1)

• core/src/trezor/lvglui/scrs/components/keyboard.py (13 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Gen check
• GitHub Check: Defs check
• GitHub Check: Style check

🔇 Additional comments (4)

core/src/trezor/lvglui/scrs/components/keyboard.py (4)

237-237: LGTM! Vibration control logic implemented correctly.

The flag prevents repeated vibrations during long presses while allowing vibration on new press events.

Also applies to: 263-263, 321-324, 336-336

---

532-532: LGTM! Consistent vibration control implementation.

Also applies to: 538-538, 591-594, 611-611

---

764-764: LGTM! Pattern matches other keyboard classes.

Also applies to: 770-770, 836-839, 868-868

---

1244-1245: LGTM! Vibration control logic correct for backspace.

Consistent with other keyboard implementations.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/misc

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[revan-zhang]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)