i18n:adjust the i18n for passphrase pin users#376
Conversation
WalkthroughA new passphrase PIN limit constant was added. UI logic now checks the current passphrase PIN space and adjusts confirmation messages when disabling the passphrase. Internationalization keys and translations were updated in multiple languages to support these new messages. Some translation files also received minor text consistency and wording updates. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (12)
core/src/trezor/lvglui/i18n/locales/es.py (2)
1033-1033: Inconsistent terminology"frase de acceso" vs "frase de contraseña" elsewhere in this file.
1034-1034: Inconsistent verb choice"Desactivar" vs "Deshabilitar" used elsewhere for passphrase.
core/src/trezor/lvglui/i18n/locales/ja.py (2)
1033-1033: Wording inconsistent「パスフレーズは有効になっていません。」 vs 既存の「パスフレーズが無効になっている。」。
1034-1034: Unnatural phrasing「デバイスを解除」→ 既存では「デバイスのロックを解除」。
core/src/trezor/lvglui/i18n/locales/ru.py (1)
1033-1034: Russian: terminology and style inconsistencies
- Термин: «Кодовая фраза» vs «Парольная фраза» (несогласованно).
- «PIN» vs «PIN-код» (несогласованно).
- Формулировка для «3 попыток» расходится со строкой на Line 953.
- Кавычки отличаются от принятого стиля (« »).
core/src/trezor/lvglui/i18n/locales/en.py (1)
1033-1034: English: consistency issues
- "failed attempts" vs earlier "failed tries" (Line 856, Line 953).
- "Passphrase turned on" vs "Passphrase is enabled/disabled" (Line 311).
- Capitalization: "hidden wallet PIN" vs "Hidden Wallet PIN" (Line 947).
core/src/trezor/lvglui/i18n/locales/ko.py (4)
21-27: Formality style is inconsistent
해요체/하십시오체 혼용.
455-455: Terminology inconsistent: ‘복구 구문’ vs ‘복구 문구’
496-496: Label wording inconsistency
‘제거하기’와 다른 곳의 ‘삭제/제거’ 혼용.
916-916: Awkward phrasing
‘지문의 가장자리를 캡처합니다’ 어색. 문체도 불일치.core/src/trezor/ui/layouts/lvgl/__init__.py (2)
1610-1611: Duplicate import
button_requestandraise_if_cancelledalready imported at file top.
1607-1608: Redundant assignment
subtitleis set to the same value in theelsebranch.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (16)
core/src/apps/common/pin_constants.py(1 hunks)core/src/apps/management/apply_settings.py(1 hunks)core/src/trezor/lvglui/i18n/keys.py(1 hunks)core/src/trezor/lvglui/i18n/locales/de.py(1 hunks)core/src/trezor/lvglui/i18n/locales/en.py(1 hunks)core/src/trezor/lvglui/i18n/locales/es.py(1 hunks)core/src/trezor/lvglui/i18n/locales/fr.py(1 hunks)core/src/trezor/lvglui/i18n/locales/it.py(1 hunks)core/src/trezor/lvglui/i18n/locales/ja.py(1 hunks)core/src/trezor/lvglui/i18n/locales/ko.py(9 hunks)core/src/trezor/lvglui/i18n/locales/pt_br.py(1 hunks)core/src/trezor/lvglui/i18n/locales/ru.py(1 hunks)core/src/trezor/lvglui/i18n/locales/zh_cn.py(1 hunks)core/src/trezor/lvglui/i18n/locales/zh_hk.py(3 hunks)core/src/trezor/lvglui/scrs/homescreen.py(1 hunks)core/src/trezor/ui/layouts/lvgl/__init__.py(1 hunks)
🔇 Additional comments (13)
core/src/trezor/lvglui/i18n/locales/it.py (1)
1033-1034: Inconsistent phrasing and verbs with existing strings.“3 tentativi non riusciti” conflicts with prior “3/5 tentativi falliti.” “Disabilitare” vs “Disattivare” used elsewhere.
core/src/trezor/lvglui/i18n/locales/zh_cn.py (1)
1033-1034: Wording and spacing inconsistent with existing strings.“3次尝试失败。滑动以继续” vs “3 次解锁失败。滑动继续”。数字与“次”间距不一致。1034 中“加密”后的逗号多余。
core/src/trezor/lvglui/i18n/locales/pt_br.py (1)
1033-1034: Terminology and capitalization inconsistent.“Frase-senha” vs “frase secreta” used elsewhere. Capitalization differs.
core/src/trezor/lvglui/i18n/locales/fr.py (1)
1033-1034: Inconsistent terminology and wordingTerminology: “phrase secrète” vs “Passphrase/phrase de passe”. Wording: “tentatives échouées” vs “infructueuses”.
core/src/trezor/lvglui/i18n/locales/de.py (1)
1033-1034: Inconsistent wording“fehlgeschlagene Versuche” vs “Fehlversuche”.
core/src/trezor/lvglui/i18n/locales/zh_hk.py (1)
1033-1033: Pronoun inconsistencyMost strings use 您. This line uses 你. Please align tone.
core/src/trezor/lvglui/i18n/keys.py (1)
2270-2272: Key prefix mismatchTITLE__DISABLE_PASSPHRASE_DESC is used as a description, not a title. Prefix is inconsistent with naming conventions.
core/src/trezor/lvglui/scrs/homescreen.py (4)
5508-5512: Off-by-one risk in threshold checkConfirm the intended boundary when space equals MAX_PASSPHRASE_PIN_NUM.
5509-5510: Inconsistent i18n key used as subtitleTITLE__DISABLE_PASSPHRASE_DESC is used as a subtitle. Verify key naming/usage.
5504-5506: Local import robustnessEnsure se_thd89 and AttachCommon exist on all builds to avoid ImportError at runtime.
5513-5519: Empty icon_path may break icon loadingVerify that FullSizeWindow handles icon_path="" safely.
core/src/apps/common/pin_constants.py (1)
29-29: No issues found.core/src/apps/management/apply_settings.py (1)
155-158: Comparator logic is correct.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
core/src/apps/base.py(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Gen check
- GitHub Check: Defs check
- GitHub Check: Style check
🔇 Additional comments (2)
core/src/apps/base.py (2)
106-108: Mixed unlock sources in Featuresunlocked uses device_is_unlocked, but private fields below still gate on config.is_unlocked. Risk of inconsistent state.
754-756: Behavior change in unlock gatingNow gates on device_is_unlocked. Will prompt if fingerprint is locked even when PIN is unlocked.
4 participants
Summary by CodeRabbit
New Features
Refactor
Style