Skip to content

i18n: update attach to pin tips#378

Merged
guowei0105 merged 1 commit intoOneKeyHQ:mainfrom
guowei0105:merge-commits
Aug 11, 2025
Merged

i18n: update attach to pin tips#378
guowei0105 merged 1 commit intoOneKeyHQ:mainfrom
guowei0105:merge-commits

Conversation

@guowei0105
Copy link
Copy Markdown
Contributor

@guowei0105 guowei0105 commented Aug 11, 2025

Summary by CodeRabbit

  • Style
    • Polished UI text across multiple languages by adding missing sentence-ending punctuation for the “Unlock your hidden wallet using PIN” message (EN, DE, ES, FR, IT, JA, KO, PT-BR, RU, ZH-HK).
  • Bug Fixes
    • Improved clarity in Simplified Chinese: refined phrasing for the passphrase status message and added proper punctuation to the unlock message.
  • Chores
    • Updated internal comments to match finalized user-facing text punctuation.

@guowei0105 guowei0105 requested a review from a team as a code owner August 11, 2025 06:08
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Aug 11, 2025

Walkthrough

Minor text updates across i18n: added trailing periods to “Unlock hidden wallet using PIN” strings in multiple locales; one zh_CN string slightly rephrased; one comment text updated. No code or API changes.

Changes

Cohort / File(s) Summary
Comment punctuation update
core/src/trezor/lvglui/i18n/keys.py
Updated a comment to add a trailing period for PASSPHRASE__ATTACH_TO_PIN_DESC.
Locale punctuation alignment
.../locales/de.py, .../locales/en.py, .../locales/es.py, .../locales/fr.py, .../locales/it.py, .../locales/ja.py, .../locales/ko.py, .../locales/pt_br.py, .../locales/ru.py, .../locales/zh_hk.py
Added trailing period to the “Unlock your hidden wallet using PIN” translation in each listed locale.
zh_CN locale updates
.../locales/zh_cn.py
Added trailing “。” to the unlock-with-PIN string; revised another sentence from “尚未开启” to “未开启”.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~6 minutes

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@revan-zhang
Copy link
Copy Markdown
Contributor

revan-zhang commented Aug 11, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
core/src/trezor/lvglui/i18n/locales/en.py (1)

896-896: Grammar: missing article

“using PIN” reads odd. Use “using a/the PIN”.

core/src/trezor/lvglui/i18n/locales/ja.py (1)

896-896: Japanese phrasing feels unnatural

Prefer “隠しウォレットのロックを解除”.

core/src/trezor/lvglui/i18n/keys.py (1)

1963-1964: Grammar in comment

“using PIN” → add article for clarity.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between e9c2257 and 93554a7.

📒 Files selected for processing (12)
  • core/src/trezor/lvglui/i18n/keys.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/de.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/en.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/es.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/fr.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/it.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/ja.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/ko.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/pt_br.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/ru.py (1 hunks)
  • core/src/trezor/lvglui/i18n/locales/zh_cn.py (2 hunks)
  • core/src/trezor/lvglui/i18n/locales/zh_hk.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Defs check
  • GitHub Check: Style check
  • GitHub Check: Gen check
🔇 Additional comments (9)
core/src/trezor/lvglui/i18n/locales/zh_cn.py (1)

1033-1033: Inconsistent spacing

“3次” vs “3 次” appears elsewhere. Please verify consistency.

core/src/trezor/lvglui/i18n/locales/de.py (1)

896-896: Inconsistent term

“Wallet” vs “Brieftasche”.

core/src/trezor/lvglui/i18n/locales/ko.py (1)

896-896: All good.

core/src/trezor/lvglui/i18n/locales/fr.py (1)

896-896: Looks good.

core/src/trezor/lvglui/i18n/locales/zh_hk.py (1)

896-896: 無問題。

core/src/trezor/lvglui/i18n/locales/it.py (1)

896-896: Tutto ok.

core/src/trezor/lvglui/i18n/locales/pt_br.py (1)

896-896: Tudo certo.

core/src/trezor/lvglui/i18n/locales/ru.py (1)

896-896: Все хорошо.

core/src/trezor/lvglui/i18n/locales/es.py (1)

896-896: Todo bien.

@guowei0105 guowei0105 merged commit 6a31a50 into OneKeyHQ:main Aug 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants