i18n: update attach to pin tips#378
Conversation
WalkthroughMinor text updates across i18n: added trailing periods to “Unlock hidden wallet using PIN” strings in multiple locales; one zh_CN string slightly rephrased; one comment text updated. No code or API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~6 minutes ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
core/src/trezor/lvglui/i18n/locales/en.py (1)
896-896: Grammar: missing article“using PIN” reads odd. Use “using a/the PIN”.
core/src/trezor/lvglui/i18n/locales/ja.py (1)
896-896: Japanese phrasing feels unnaturalPrefer “隠しウォレットのロックを解除”.
core/src/trezor/lvglui/i18n/keys.py (1)
1963-1964: Grammar in comment“using PIN” → add article for clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (12)
core/src/trezor/lvglui/i18n/keys.py(1 hunks)core/src/trezor/lvglui/i18n/locales/de.py(1 hunks)core/src/trezor/lvglui/i18n/locales/en.py(1 hunks)core/src/trezor/lvglui/i18n/locales/es.py(1 hunks)core/src/trezor/lvglui/i18n/locales/fr.py(1 hunks)core/src/trezor/lvglui/i18n/locales/it.py(1 hunks)core/src/trezor/lvglui/i18n/locales/ja.py(1 hunks)core/src/trezor/lvglui/i18n/locales/ko.py(1 hunks)core/src/trezor/lvglui/i18n/locales/pt_br.py(1 hunks)core/src/trezor/lvglui/i18n/locales/ru.py(1 hunks)core/src/trezor/lvglui/i18n/locales/zh_cn.py(2 hunks)core/src/trezor/lvglui/i18n/locales/zh_hk.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Defs check
- GitHub Check: Style check
- GitHub Check: Gen check
🔇 Additional comments (9)
core/src/trezor/lvglui/i18n/locales/zh_cn.py (1)
1033-1033: Inconsistent spacing“3次” vs “3 次” appears elsewhere. Please verify consistency.
core/src/trezor/lvglui/i18n/locales/de.py (1)
896-896: Inconsistent term“Wallet” vs “Brieftasche”.
core/src/trezor/lvglui/i18n/locales/ko.py (1)
896-896: All good.core/src/trezor/lvglui/i18n/locales/fr.py (1)
896-896: Looks good.core/src/trezor/lvglui/i18n/locales/zh_hk.py (1)
896-896: 無問題。core/src/trezor/lvglui/i18n/locales/it.py (1)
896-896: Tutto ok.core/src/trezor/lvglui/i18n/locales/pt_br.py (1)
896-896: Tudo certo.core/src/trezor/lvglui/i18n/locales/ru.py (1)
896-896: Все хорошо.core/src/trezor/lvglui/i18n/locales/es.py (1)
896-896: Todo bien.
Summary by CodeRabbit