Skip to content

fix(core): fix mnemonic display issue#381

Merged
somebodyLi merged 1 commit intomainfrom
fix/misc
Aug 12, 2025
Merged

fix(core): fix mnemonic display issue#381
somebodyLi merged 1 commit intomainfrom
fix/misc

Conversation

@somebodyLi
Copy link
Copy Markdown
Contributor

@somebodyLi somebodyLi commented Aug 12, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Improved mnemonic display during device reset to prevent content overflow and clipping.
    • Ensures consistent layout and readability across different screen sizes, reducing scrolling glitches.
    • Provides a more stable viewing experience when showing long content.

@somebodyLi somebodyLi requested a review from a team as a code owner August 12, 2025 06:56
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Aug 12, 2025

Walkthrough

A single UI layout change in reset_device.py adds a max-height style to MnemonicDisplay.content_area within add_indicator, placed after click indicator setup. No other logic or API changes.

Changes

Cohort / File(s) Summary
UI layout constraint update
core/src/trezor/lvglui/scrs/reset_device.py
Added self.content_area.set_style_max_height(574, 0) in MnemonicDisplay.add_indicator to cap content area height.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between e336b9a and cb1b55c.

📒 Files selected for processing (1)
  • core/src/trezor/lvglui/scrs/reset_device.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Gen check
  • GitHub Check: Defs check
  • GitHub Check: Style check
🔇 Additional comments (1)
core/src/trezor/lvglui/scrs/reset_device.py (1)

136-136: Max height applied only with indicator

Layout differs when indicator_text is None. Is this intentional?

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/misc

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@revan-zhang
Copy link
Copy Markdown
Contributor

revan-zhang commented Aug 12, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@somebodyLi somebodyLi enabled auto-merge (squash) August 12, 2025 07:00
@somebodyLi somebodyLi merged commit b77b710 into main Aug 12, 2025
9 checks passed
@somebodyLi somebodyLi deleted the fix/misc branch August 12, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants