Skip to content

add ble connection status query && clear session when device is locked#385

Merged
lihuanhuan merged 2 commits intoOneKeyHQ:mainfrom
lihuanhuan:pro_main
Aug 26, 2025
Merged

add ble connection status query && clear session when device is locked#385
lihuanhuan merged 2 commits intoOneKeyHQ:mainfrom
lihuanhuan:pro_main

Conversation

@lihuanhuan
Copy link
Copy Markdown
Contributor

@lihuanhuan lihuanhuan commented Aug 26, 2025

Summary by CodeRabbit

  • New Features

    • Automatic session clearing during lock/unlock to enhance device security and consistency.
    • Improved Bluetooth handling: initializes BLE connection status automatically for more reliable connectivity.
  • Bug Fixes

    • Fixed rare inconsistencies where session state could persist after locking/unlocking.
    • Prevented unnecessary session-related prompts in certain USB and button-interaction scenarios.

@lihuanhuan lihuanhuan requested a review from a team as a code owner August 26, 2025 14:24
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Aug 26, 2025

Walkthrough

Adds a Python API se_thd89.clear_session() and wires it into device lock/unlock flows. Replaces prior passphrase cache session-ending logic with secure element session clearing in base and UART paths. Adds a BLE connected-state probe in UART when status is unknown. No public function signatures changed.

Changes

Cohort / File(s) Change Summary
SE session API exposure
core/embed/extmod/modtrezorcrypto/modtrezorcrypto-se-thd89.h
Introduces clear_session() Python binding for THD89 secure element, mapping to se_sessionClear(). Adds object and globals table entry.
Lock flow update
core/src/apps/base.py
Calls se_thd89.clear_session() at start of lock_device() when initialized and PIN-protected. Removes passphrase cache end_current_session() path.
UART handling and BLE probe
core/src/trezor/uart.py
Replaces passphrase cache session-ending with se_thd89.clear_session() in handle_usb_state and _deal_button_press. Adds BLE status request when utils.BLE_CONNECTED is None in fetch_ble_info().

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge Base: Disabled due to data retention organization setting

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9f23c6d and 5c12860.

⛔ Files ignored due to path filters (1)
  • core/mocks/generated/trezorcrypto/se_thd89.pyi is excluded by !**/generated/**
📒 Files selected for processing (3)
  • core/embed/extmod/modtrezorcrypto/modtrezorcrypto-se-thd89.h (2 hunks)
  • core/src/apps/base.py (1 hunks)
  • core/src/trezor/uart.py (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Defs check
  • GitHub Check: Gen check
  • GitHub Check: Style check
🔇 Additional comments (6)
core/src/apps/base.py (1)

554-555: No issue

core/embed/extmod/modtrezorcrypto/modtrezorcrypto-se-thd89.h (2)

138-148: No issue


1163-1165: No issue

core/src/trezor/uart.py (3)

213-216: Uncaught errors from clear_session could break loop

Confirm clear_session never raises here. If it can, this loop may clear and drop state.


366-369: Same risk on button short-press path

Confirm clear_session is safe and non-raising on all devices.


628-630: BLE protocol compatibility

New ctrl 0x81/0x05. Verify it’s supported on all target BLE firmwares.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@revan-zhang
Copy link
Copy Markdown
Contributor

revan-zhang commented Aug 26, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@lihuanhuan lihuanhuan enabled auto-merge (squash) August 26, 2025 14:30
@lihuanhuan lihuanhuan merged commit a76a5f8 into OneKeyHQ:main Aug 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants