fix(core/tron): fix the tron sign message issue#386
Conversation
WalkthroughRemoved deprecated flag from TronMessageType.V1 in proto, added V1 constant to the Python enum, and bumped firmware patch version from 0 to 1. No other logic or structure changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
common/protob/messages-tron.proto (3)
62-67: Spelling: "resouce"
50-50: Inconsistent "base58" vs "base 58"Also applies to: 55-55, 74-74
59-60: Comment mismatch for call_token_value/asset_id
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
common/protob/messages-tron.proto(1 hunks)core/embed/firmware/version.h(1 hunks)core/src/trezor/enums/TronMessageType.py(1 hunks)
👮 Files not reviewed due to content moderation or server errors (2)
- core/src/trezor/enums/TronMessageType.py
- core/embed/firmware/version.h
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Gen check
- GitHub Check: Style check
- GitHub Check: Defs check
Summary by CodeRabbit
Bug Fixes
Chores